Skip to content

prowgen: use preset for registry pull credentials volume #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Mar 17, 2026
Merged

prowgen: use preset for registry pull credentials volume #4994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ea396
integration: fix script to not glob capture dotfiles
petr-muller Mar 14, 2026
eaa4904
prowgen: use preset for registry pull credentials volume
petr-muller Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ...estdata/zz_fixture_postsubmit_TestFromCIOperatorConfigToProwYaml_Custom_test_timeout.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ postsubmits:
labels:
ci-operator.openshift.io/is-promotion: "true"
ci.openshift.io/generator: prowgen
presets.ci.openshift.io/registry-pull: "true"
max_concurrency: 1
name: branch-ci-super-duper-branch-images
spec:
Expand All @@ -55,9 +56,6 @@ postsubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/push-secret
name: push-secret
readOnly: true
Expand All @@ -69,9 +67,6 @@ postsubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: push-secret
secret:
secretName: registry-push-credentials-ci-central
Expand Down
7 changes: 1 addition & 6 deletions ...ubmit_TestFromCIOperatorConfigToProwYaml_Input_is_YAML_and_it_is_correctly_processed.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ postsubmits:
labels:
ci-operator.openshift.io/is-promotion: "true"
ci.openshift.io/generator: prowgen
presets.ci.openshift.io/registry-pull: "true"
max_concurrency: 1
name: branch-ci-super-duper-branch-images
spec:
Expand All @@ -55,9 +56,6 @@ postsubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/push-secret
name: push-secret
readOnly: true
Expand All @@ -69,9 +67,6 @@ postsubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: push-secret
secret:
secretName: registry-push-credentials-ci-central
Expand Down
7 changes: 1 addition & 6 deletions ...pect_one_presubmit__pre_post_submit_images_jobs._Existing_job_should_not_be_changed..yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ postsubmits:
ci-operator.openshift.io/is-promotion: "true"
ci-operator.openshift.io/variant: rhel
ci.openshift.io/generator: prowgen
presets.ci.openshift.io/registry-pull: "true"
max_concurrency: 1
name: branch-ci-super-duper-branch-rhel-images
spec:
Expand Down Expand Up @@ -59,9 +60,6 @@ postsubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/push-secret
name: push-secret
readOnly: true
Expand All @@ -73,9 +71,6 @@ postsubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: push-secret
secret:
secretName: registry-push-credentials-ci-central
Expand Down
7 changes: 1 addition & 6 deletions ...est_and_images__no_previous_jobs._Expect_test_presubmit__pre_post_submit_images_jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ postsubmits:
labels:
ci-operator.openshift.io/is-promotion: "true"
ci.openshift.io/generator: prowgen
presets.ci.openshift.io/registry-pull: "true"
max_concurrency: 1
name: branch-ci-super-duper-branch-images
spec:
Expand All @@ -36,9 +37,6 @@ postsubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/push-secret
name: push-secret
readOnly: true
Expand All @@ -50,9 +48,6 @@ postsubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: push-secret
secret:
secretName: registry-push-credentials-ci-central
Expand Down
14 changes: 2 additions & 12 deletions ...testdata/zz_fixture_presubmit_TestFromCIOperatorConfigToProwYaml_Custom_test_timeout.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ presubmits:
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
presets.ci.openshift.io/registry-pull: "true"
name: pull-ci-super-duper-branch-images
rerun_command: /test images
spec:
Expand All @@ -36,9 +37,6 @@ presubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -47,9 +45,6 @@ presubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand All @@ -67,6 +62,7 @@ presubmits:
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
presets.ci.openshift.io/registry-pull: "true"
name: pull-ci-super-duper-branch-unit
rerun_command: /test unit
spec:
Expand Down Expand Up @@ -99,9 +95,6 @@ presubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -110,9 +103,6 @@ presubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand Down
14 changes: 2 additions & 12 deletions ...ubmit_TestFromCIOperatorConfigToProwYaml_Input_is_YAML_and_it_is_correctly_processed.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ presubmits:
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
presets.ci.openshift.io/registry-pull: "true"
name: pull-ci-super-duper-branch-images
rerun_command: /test images
spec:
Expand All @@ -36,9 +37,6 @@ presubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -47,9 +45,6 @@ presubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand All @@ -66,6 +61,7 @@ presubmits:
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
presets.ci.openshift.io/registry-pull: "true"
name: pull-ci-super-duper-branch-unit
rerun_command: /test unit
spec:
Expand Down Expand Up @@ -98,9 +94,6 @@ presubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -109,9 +102,6 @@ presubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand Down
14 changes: 2 additions & 12 deletions ...pect_one_presubmit__pre_post_submit_images_jobs._Existing_job_should_not_be_changed..yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ presubmits:
ci-operator.openshift.io/variant: rhel
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
presets.ci.openshift.io/registry-pull: "true"
name: pull-ci-super-duper-branch-rhel-images
rerun_command: /test rhel-images
spec:
Expand All @@ -38,9 +39,6 @@ presubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -49,9 +47,6 @@ presubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand All @@ -69,6 +64,7 @@ presubmits:
ci-operator.openshift.io/variant: rhel
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
presets.ci.openshift.io/registry-pull: "true"
name: pull-ci-super-duper-branch-rhel-unit
rerun_command: /test rhel-unit
spec:
Expand Down Expand Up @@ -102,9 +98,6 @@ presubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -113,9 +106,6 @@ presubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand Down
14 changes: 2 additions & 12 deletions ...est_and_images__no_previous_jobs._Expect_test_presubmit__pre_post_submit_images_jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ presubmits:
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
presets.ci.openshift.io/registry-pull: "true"
name: pull-ci-super-duper-branch-images
rerun_command: /test images
spec:
Expand All @@ -36,9 +37,6 @@ presubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -47,9 +45,6 @@ presubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand All @@ -66,6 +61,7 @@ presubmits:
labels:
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
presets.ci.openshift.io/registry-pull: "true"
name: pull-ci-super-duper-branch-unit
rerun_command: /test unit
spec:
Expand Down Expand Up @@ -98,9 +94,6 @@ presubmits:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -109,9 +102,6 @@ presubmits:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand Down
6 changes: 0 additions & 6 deletions ...prow-plugin/testdata/zz_fixture_TestGenerateProwJob_additional_PR_from_the_same_repo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ spec:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Comment on lines 52 to 57
Expand All @@ -63,9 +60,6 @@ spec:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand Down
6 changes: 0 additions & 6 deletions ...multi-pr-prow-plugin/testdata/zz_fixture_TestGenerateProwJob_multiple_additional_PRs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,6 @@ spec:
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -76,9 +73,6 @@ spec:
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand Down
6 changes: 0 additions & 6 deletions ...estHandle_trigger_a_single_multi_pr_job_run_with_additional_PR_from_a_different_repo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
Expand All @@ -77,9 +74,6 @@
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Expand Down
Loading
Loading