Skip to content

Add openshift-org-aws Cluster Profile Set#4989

Open
danilo-gemoli wants to merge 1 commit intoopenshift:mainfrom
danilo-gemoli:feat/add-openshift-org-aws-profile
Open

Add openshift-org-aws Cluster Profile Set#4989
danilo-gemoli wants to merge 1 commit intoopenshift:mainfrom
danilo-gemoli:feat/add-openshift-org-aws-profile

Conversation

@danilo-gemoli
Copy link
Contributor

@danilo-gemoli danilo-gemoli commented Mar 6, 2026

This adds the first cluster profile set.
Require #4983

Summary by CodeRabbit

  • New Features
    • Added a new OpenShift cluster profile for AWS environments, now available as a configuration option for cluster provisioning and lease type management.

@openshift-ci-robot
Copy link
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Walkthrough

Adds a new OpenShift AWS cluster profile constant ("openshift-org-aws") and integrates it into the cluster profile system by updating the public profiles list, cluster type mapping, and lease type mapping.

Changes

Cohort / File(s) Summary
Cluster Profile Addition
pkg/api/types.go
Added new constant ClusterProfileOpenshiftOrgAWS with value "openshift-org-aws". Integrated into ClusterProfiles() list output, ClusterType() aws group, and LeaseType() mapping returning "openshift-org-aws-quota-slice".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding a new cluster profile set called 'openshift-org-aws' to the codebase.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Stable And Deterministic Test Names ✅ Passed This check evaluates Ginkgo test names, but the PR only modifies API type definitions with no test code.
Test Structure And Quality ✅ Passed This PR only modifies constants and mappings in pkg/api/types.go with no Ginkgo test code or new tests added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from Prucek and liangxia March 6, 2026 08:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026
@danilo-gemoli
Copy link
Contributor Author

/test e2e

@danilo-gemoli
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@danilo-gemoli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration b5c344e link true /test integration
ci/prow/breaking-changes b5c344e link false /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants