This repository was archived by the owner on Jun 14, 2019. It is now read-only.
pkg/steps/release/create_release: Drop SkipLogs for release-* pods #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Contributor
|
/approve |
openshift-ci-robot
added
lgtm
This came in with ad5a4e3 (Implement a Golang cluster installer job that hides the template, 2019-03-04, openshift#288), but the lack of 'oc adm release new' logs is making it hard to debug broken ImageStream retrieval [1]. I don't understand the bulk of that commit, so hopefully this narrow pivot doesn't break anything... [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1707928#c3
wking
force-pushed
the
restore-logs-for-new-releases
branch
from
06d00fd to
3d1ffc2
Compare
Member
Author
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, stevekuznetsov, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came in with ad5a4e3 (#288), but the lack of
oc adm release newlogs is making it hard to debug broken ImageStream retrieval. I don't understand the bulk of that commit, so hopefully this narrow pivot doesn't break anything...CC @smarterclayton, @stevekuznetsov