This repository was archived by the owner on Jun 14, 2019. It is now read-only.
When --template is specified, ignore whatever test with that name is defined #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined As we move templates into the ci-operator, we need a way to stage the changes for sets of jobs and move gradually. When a user provides --template on the command line, ignore any job with the same name so that we can begin moving those to internal definitions.
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
Author
|
In order for us to start trying to move templates inline, we need a way to keep backcompat with existing jobs (which use --template) and then allow us to test a few using the version coming out of this binary, then migrate the rest by regenerating ci-operator prowgen. This PR allows us to let |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we move templates into the ci-operator, we need a way to stage the
changes for sets of jobs and move gradually. When a user provides
--template on the command line, ignore any job with the same name so that
we can begin moving those to internal definitions.
How would we move jobs over to built in steps: