Skip to content

DNM: Test PR for ClusterBot, Add webhook readiness check before starting manager #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MahnoorAsghar wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

DNM: Test PR for ClusterBot, Add webhook readiness check before starting manager #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,19 @@ func setupChecks(mgr ctrl.Manager) {
}
}

// setupWebhookReadinessCheck adds a readiness check that blocks the pod from
// entering "Ready" state (and thus from being added to the Service's endpoints)
// until the webhook server is actually listening. This prevents a race where
// the Kubernetes API server tries to route admission webhook calls to this pod
// before the webhook TLS server is up, which would cause "no endpoints
// available" errors for BareMetalHost operations.
func setupWebhookReadinessCheck(mgr ctrl.Manager) {
if err := mgr.AddReadyzCheck("webhook", mgr.GetWebhookServer().StartedChecker()); err != nil {
setupLog.Error(err, "unable to create ready check for webhook server")
os.Exit(1)
}
}

func setupWebhooks(mgr ctrl.Manager) {
if err := (&webhooks.BareMetalHost{}).SetupWebhookWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create webhook", "webhook", "BareMetalHost")
Expand Down Expand Up @@ -405,6 +418,7 @@ func main() {
setupChecks(mgr)

if enableWebhook {
setupWebhookReadinessCheck(mgr)
setupWebhooks(mgr)
}

Expand Down