Skip to content

fix: improve access request error message #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
feichashao wants to merge 1 commit into from
Closed

fix: improve access request error message #874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/accessrequest/accessRequest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import (
"github.com/spf13/cobra"
)

const jiraTokenHelpMessage = "Ensure you have access to the issue and your JIRA token is valid.\nSet token using either:\n - Command: ocm-backplane config set %s <token value>\n - Environment variable: export JIRA_API_TOKEN=<token value>"

func getJiraBaseURL() string {
bpConfig, err := config.GetBackplaneConfiguration()
if err != nil {
Expand Down Expand Up @@ -117,7 +119,7 @@ func verifyAndPossiblyRetrieveIssue(bpConfig *config.BackplaneConfiguration, isP

issue, _, err := jiraClient.DefaultIssueService.Get(issueID, nil)
if err != nil {
return nil, err
return nil, fmt.Errorf("failed to verify JIRA issue '%s': %w\n"+jiraTokenHelpMessage, issueID, err, config.JiraTokenViperKey)
}

return issue, nil
Expand Down Expand Up @@ -148,7 +150,7 @@ func createNotificationIssue(bpConfig *config.BackplaneConfiguration, isProd boo

issue, _, err := jiraClient.DefaultIssueService.Create(issue)
if err != nil {
return nil, err
return nil, fmt.Errorf("failed to create JIRA notification issue: %w\n"+jiraTokenHelpMessage, err, config.JiraTokenViperKey)
}

return issue, nil
Expand Down