-
Notifications
You must be signed in to change notification settings - Fork 79
feat: update to aws-sdk-go-v2 #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BATMAN-JD The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
==========================================
- Coverage 47.22% 46.93% -0.30%
==========================================
Files 46 46
Lines 6621 6673 +52
==========================================
+ Hits 3127 3132 +5
- Misses 3175 3224 +49
+ Partials 319 317 -2
🚀 New features to boost your workflow:
|
|
@BATMAN-JD: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What is being added?
What Stayed the Same
✅ Zero functional changes - all business logic identical
✅ Same AWS operations performed
✅ Same error handling behavior (different types, same logic)
✅ No API endpoint changes
✅ No configuration changes required for deployments
I have tested this locally
I have included unit tests
I have updated any corresponding documentation
Steps To Manually Test
Please provide us steps to reproduce the scenarios needed to test this. If an integration test is provided, let us know how to run it. If not, enumerate the steps to validate this does what it's supposed to.
SREP-1187