NO-ISSUE: [master] Bump OCP versions: 4.22, 4.14#9954
NO-ISSUE: [master] Bump OCP versions: 4.22, 4.14#9954danmanor wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@danmanor: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@danmanor: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
size/M
WalkthroughThe PR updates OpenShift image references across multiple configuration files, bumping RHCOS 4.22 pre-release versions from ec.2 to ec.3 and updating 4.14 release versions from 4.14.61 to 4.14.62 across various architectures. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
deploy/podman/configmap.yml (1)
25-30: Consider generating these embedded JSON values from a single source of truth.Keeping large JSON blobs duplicated across manifests is drift-prone; an automated generation step from
data/default_os_images.jsonanddata/default_release_images.jsonwould improve maintainability.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deploy/podman/configmap.yml` around lines 25 - 30, The configmap includes large embedded JSON blobs in the OS_IMAGES and RELEASE_IMAGES variables which risk drift; refactor so the manifest is generated from single-source JSON files (data/default_os_images.json and data/default_release_images.json) during your build/CI step, update the generator script (or add a new build script referenced by your Makefile/CI pipeline) to read those files and inject their content into the ConfigMap template used to produce deploy/podman/configmap.yml, and replace the hard-coded OS_IMAGES and RELEASE_IMAGES entries with template placeholders that the generator fills (look for OS_IMAGES and RELEASE_IMAGES in deploy/podman/configmap.yml and the build/Makefile or CI job that produces manifests).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@deploy/podman/configmap.yml`:
- Around line 25-30: The configmap includes large embedded JSON blobs in the
OS_IMAGES and RELEASE_IMAGES variables which risk drift; refactor so the
manifest is generated from single-source JSON files (data/default_os_images.json
and data/default_release_images.json) during your build/CI step, update the
generator script (or add a new build script referenced by your Makefile/CI
pipeline) to read those files and inject their content into the ConfigMap
template used to produce deploy/podman/configmap.yml, and replace the hard-coded
OS_IMAGES and RELEASE_IMAGES entries with template placeholders that the
generator fills (look for OS_IMAGES and RELEASE_IMAGES in
deploy/podman/configmap.yml and the build/Makefile or CI job that produces
manifests).
ℹ️ Review info
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (7)
config/manager/manager.yamlconfig/samples/agent-install.openshift.io_v1beta1_agentserviceconfig.yamldata/default_os_images.jsondata/default_release_images.jsondeploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yamldeploy/podman/configmap.ymlopenshift/template.yaml
|
@danmanor: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing as duplicate of #9968 |
3 participants
OpenShift updates: 4.22.0-ec.2-multi -> 4.22.0-ec.3-multi, 4.14.61 -> 4.14.62, 4.14.61-multi -> 4.14.62-multi, 4.22.0-ec.2 -> 4.22.0-ec.3
RHCOS updates: 4.22.0-ec.2 -> 4.22.0-ec.3
/test edge-e2e-metal-assisted-4-22 edge-e2e-metal-assisted-4-14
/cc @rccrdpccl @gamli75
Summary by CodeRabbit