Skip to content

OCPEDGE-2367: Add support for platform none and external on TNA clusters topology#9953

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:v2.50from
openshift-cherrypick-robot:cherry-pick-8830-to-v2.50
Mar 4, 2026
Merged

OCPEDGE-2367: Add support for platform none and external on TNA clusters topology#9953
openshift-merge-bot[bot] merged 1 commit intoopenshift:v2.50from
openshift-cherrypick-robot:cherry-pick-8830-to-v2.50

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #8830

/assign andrej1991

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 2, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OCPEDGE-2367

Details

In response to this:

This is an automated cherry-pick of #8830

/assign andrej1991

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2026

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: andrej1991.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

This is an automated cherry-pick of #8830

/assign andrej1991

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 2, 2026
@openshift-ci openshift-ci bot requested review from gamli75 and jhernand March 2, 2026 10:56
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.82%. Comparing base (bdf24a3) to head (6d15e92).
⚠️ Report is 3 commits behind head on v2.50.

Files with missing lines Patch % Lines
internal/common/common.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            v2.50    #9953      +/-   ##
==========================================
- Coverage   43.82%   43.82%   -0.01%     
==========================================
  Files         414      414              
  Lines       71875    71873       -2     
==========================================
- Hits        31501    31497       -4     
- Misses      37513    37514       +1     
- Partials     2861     2862       +1     
Files with missing lines Coverage Δ
internal/featuresupport/features_misc.go 93.02% <100.00%> (-0.04%) ⬇️
internal/featuresupport/features_platforms.go 96.60% <ø> (-0.02%) ⬇️
internal/provider/platform.go 0.00% <ø> (ø)
internal/common/common.go 30.51% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pastequo
Copy link
Contributor

pastequo commented Mar 2, 2026

/retest

3 similar comments
@pastequo
Copy link
Contributor

pastequo commented Mar 2, 2026

/retest

@pastequo
Copy link
Contributor

pastequo commented Mar 2, 2026

/retest

@andrej1991
Copy link
Contributor

/retest

@pastequo
Copy link
Contributor

pastequo commented Mar 3, 2026

/lgtm

@pastequo pastequo changed the title [v2.50] OCPEDGE-2367: Add support for platform none and external on TNA clusters topology OCPEDGE-2367: Add support for platform none and external on TNA clusters topology Mar 3, 2026
@pastequo
Copy link
Contributor

pastequo commented Mar 3, 2026

/override ci/prow/e2e-metal-assisted-day2 ci/prow/e2e-vsphere-assisted

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2026

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/e2e-metal-assisted-day2, ci/prow/e2e-vsphere-assisted

Details

In response to this:

/override ci/prow/e2e-metal-assisted-day2 ci/prow/e2e-vsphere-assisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pastequo pastequo added approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 3, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pastequo
Copy link
Contributor

pastequo commented Mar 3, 2026

/override ci/prow/e2e-metal-assisted-day2 ci/prow/e2e-vsphere-assisted

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2026

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/e2e-metal-assisted-day2, ci/prow/e2e-vsphere-assisted

Details

In response to this:

/override ci/prow/e2e-metal-assisted-day2 ci/prow/e2e-vsphere-assisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2026
@pastequo
Copy link
Contributor

pastequo commented Mar 4, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@pastequo
Copy link
Contributor

pastequo commented Mar 4, 2026

/override ci/prow/e2e-metal-assisted-day2 ci/prow/e2e-vsphere-assisted

@openshift-ci
Copy link

openshift-ci bot commented Mar 4, 2026

@pastequo: Overrode contexts on behalf of pastequo: ci/prow/e2e-metal-assisted-day2, ci/prow/e2e-vsphere-assisted

Details

In response to this:

/override ci/prow/e2e-metal-assisted-day2 ci/prow/e2e-vsphere-assisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 4, 2026

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-assisted 6d15e92 link true /test e2e-vsphere-assisted
ci/prow/e2e-metal-assisted-day2 6d15e92 link true /test e2e-metal-assisted-day2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bdfbf2f into openshift:v2.50 Mar 4, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants