NO-ISSUE: Update github.com/openshift/hive/apis digest to 3ea8a7f#9923
NO-ISSUE: Update github.com/openshift/hive/apis digest to 3ea8a7f#9923red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
Conversation
red-hat-konflux
Bot
added
api-sync
approved
|
openshift-ci-robot
added
the
jira/valid-reference
|
@red-hat-konflux[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
size/XS
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@api/go.mod`:
- Line 13: The require line uses a bare commit hash for module
github.com/openshift/hive/apis (a80802fdca76), which is not valid Go module
syntax; fix it by running the suggested `go get
github.com/openshift/hive/apis@a80802fdca76` to let Go compute and write the
correct pseudo-version into go.mod, or manually replace the commit with the
generated pseudo-version (vX.Y.Z-yyyymmddhhmmss-<commithash>) so the require
directive is a valid semantic/pseudo-version.
In `@go.mod`:
- Line 62: go.mod currently pins github.com/openshift/hive/apis to a bare commit
hash a80802fdca76 which is invalid; run go mod tidy to convert that entry into a
proper pseudo-version (e.g. v0.0.0-YYYYMMDDHHMMSS-a80802fdca76) and then run go
mod vendor to update vendor/modules.txt so the vendor directory matches the new
go.mod requirement (resolving the mismatch between go.mod and
vendor/modules.txt).
ℹ️ Review info
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
api/go.modgo.mod
| github.com/openshift/assisted-service/models v0.0.0 | ||
| github.com/openshift/custom-resource-status v1.1.3-0.20220503160415-f2fdb4999d87 | ||
| github.com/openshift/hive/apis v0.0.0-20231220215202-ad99b9e52d27 | ||
| github.com/openshift/hive/apis a80802fdca76 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
find . -name "go.mod" -type f | head -20Repository: openshift/assisted-service
Length of output: 123
🏁 Script executed:
head -20 api/go.mod && echo "---" && sed -n '13p' api/go.modRepository: openshift/assisted-service
Length of output: 661
🌐 Web query:
Go module require directive syntax version format valid semver pseudo-version
💡 Result:
require directive syntax (in go.mod)
require <module-path> <module-version>You can also use a parenthesized block:
require (
<module-path> <module-version>
)The <module-path> is the module path, and for major versions v2+ it must end with /vN (for example, example.com/mod/v2). [1]
Valid version format (canonical)
In a require (and replace / exclude), the version must be a canonical Go module version, which starts with v and follows Semantic Versioning (SemVer):
- Release:
vMAJOR.MINOR.PATCH(example:v1.2.3) - Optional pre-release:
v1.2.3-alpha.1 - Optional build metadata:
v1.2.3+meta(Go may rewrite build metadata to keep versions totally ordered) [2]
Examples of valid versions: v0.0.0, v1.12.134, v8.0.5-pre, v2.0.9+meta. [2]
Pseudo-version format (Go-generated)
A pseudo-version is a SemVer pre-release that encodes a specific VCS revision (commit) and timestamp. It has three parts: base, UTC timestamp yyyymmddhhmmss, and 12-hex revision id. [2]
Go uses one of these forms: [2]
- No prior tag:
vX.0.0-yyyymmddhhmmss-abcdefabcdef
- Prior tag is a pre-release
vX.Y.Z-pre:
vX.Y.Z-pre.0.yyyymmddhhmmss-abcdefabcdef
- Prior tag is a release
vX.Y.Z:
vX.Y.(Z+1)-0.yyyymmddhhmmss-abcdefabcdef
Example: basev1.2.3→v1.2.4-0.20191109021931-daa7c04131f5[2]
Go tooling will generate these automatically when you depend on an untagged commit. [1]
Sources: Go go.mod reference [1], Go Modules Reference (versions & pseudo-versions) [2].
Use a valid Go module version instead of a bare commit hash.
The require directive requires either a semantic version (e.g., v1.2.3) or a pseudo-version in the format vX.Y.Z-yyyymmddhhmmss-commithash. The bare commit hash a80802fdca76 is not valid Go module syntax. Run go get github.com/openshift/hive/apis@a80802fdca76 to generate and apply the correct pseudo-version.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@api/go.mod` at line 13, The require line uses a bare commit hash for module
github.com/openshift/hive/apis (a80802fdca76), which is not valid Go module
syntax; fix it by running the suggested `go get
github.com/openshift/hive/apis@a80802fdca76` to let Go compute and write the
correct pseudo-version into go.mod, or manually replace the commit with the
generated pseudo-version (vX.Y.Z-yyyymmddhhmmss-<commithash>) so the require
directive is a valid semantic/pseudo-version.
| github.com/openshift/custom-resource-status v1.1.3-0.20220503160415-f2fdb4999d87 | ||
| github.com/openshift/generic-admission-server v1.14.1-0.20231020105858-8dcc3c9b298f | ||
| github.com/openshift/hive/apis v0.0.0-20260127213836-e33d70397d57 | ||
| github.com/openshift/hive/apis a80802fdca76 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cd / && find . -name "go.mod" -type f 2>/dev/null | head -1Repository: openshift/assisted-service
Length of output: 100
🏁 Script executed:
cat go.mod | head -80 | tail -30Repository: openshift/assisted-service
Length of output: 1617
🏁 Script executed:
# Check the exact line 62
sed -n '60,65p' go.modRepository: openshift/assisted-service
Length of output: 488
🏁 Script executed:
# Test go mod tidy behavior
go mod tidy -v 2>&1 | head -50Repository: openshift/assisted-service
Length of output: 3069
🏁 Script executed:
# Check if the module can be resolved
go list -m -json github.com/openshift/hive/apis 2>&1Repository: openshift/assisted-service
Length of output: 577
Fix bare commit hash and vendor inconsistency in go.mod.
The bare commit hash a80802fdca76 for github.com/openshift/hive/apis is invalid. Run go mod tidy to convert it to a proper pseudo-version. However, this creates a vendor inconsistency: go.mod will require v0.0.0-20260219202727-a80802fdca76, while vendor/modules.txt has v0.0.0-20260127213836-e33d70397d57. Run go mod vendor after tidying to sync the vendor directory with go.mod.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 62, go.mod currently pins github.com/openshift/hive/apis to a
bare commit hash a80802fdca76 which is invalid; run go mod tidy to convert that
entry into a proper pseudo-version (e.g. v0.0.0-YYYYMMDDHHMMSS-a80802fdca76) and
then run go mod vendor to update vendor/modules.txt so the vendor directory
matches the new go.mod requirement (resolving the mismatch between go.mod and
vendor/modules.txt).
2c9fb62 to
8d66a6c
Compare
red-hat-konflux
Bot
changed the title
|
New changes are detected. LGTM label has been removed. |
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/hive-api-synchronization
branch
from
8d66a6c to
a548137
Compare
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/hive-api-synchronization
branch
from
a548137 to
1203292
Compare
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/hive-api-synchronization
branch
from
1203292 to
f82bbd5
Compare
red-hat-konflux
Bot
changed the title
There was a problem hiding this comment.
♻️ Duplicate comments (2)
go.mod (1)
62-62:⚠️ Potential issue | 🟠 MajorPin
github.com/openshift/hive/apiswith a pseudo-version, not a raw SHA.Line 62 has the same invalid format (
afd410177cb1). Convert it viago get github.com/openshift/hive/apis@afd410177cb1, then ensurevendor/modules.txtis synchronized.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 62, The go.mod entry for github.com/openshift/hive/apis currently uses a raw SHA suffix ("afd410177cb1"); replace it with a proper pseudo-version by running: go get github.com/openshift/hive/apis@afd410177cb1 to update go.mod (this will convert the raw SHA into a pseudo-version for the module), then run go mod tidy and go mod vendor to synchronize vendor/modules.txt; ensure the updated go.mod contains the pseudo-version for github.com/openshift/hive/apis and that vendor/modules.txt reflects the change.api/go.mod (1)
13-13:⚠️ Potential issue | 🟠 MajorUse a valid Go module version (not a bare commit hash).
Line 13 uses
afd410177cb1directly;requireentries must be a SemVer or Go pseudo-version. Please rungo get github.com/openshift/hive/apis@afd410177cb1and commit the generated pseudo-version (and synced vendor metadata if applicable).#!/bin/bash set -euo pipefail echo "Checking bare-hash module versions for hive/apis..." rg -n 'github\.com/openshift/hive/apis\s+[0-9a-f]{12,40}$' api/go.mod go.mod || true echo echo "Checking resolved version recorded in vendor/modules.txt (if present)..." if [[ -f vendor/modules.txt ]]; then rg -n 'github\.com/openshift/hive/apis' vendor/modules.txt || true else echo "vendor/modules.txt not present" fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@api/go.mod` at line 13, The require line for module "github.com/openshift/hive/apis" uses a bare commit hash (afd410177cb1) instead of a SemVer or pseudo-version; run `go get github.com/openshift/hive/apis@afd410177cb1` to resolve and record the generated pseudo-version, then commit the updated go.mod (and updated vendor metadata/modules.txt if you vendor) so the module requirement is a valid Go pseudo-version rather than a raw hash.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@api/go.mod`:
- Line 13: The require line for module "github.com/openshift/hive/apis" uses a
bare commit hash (afd410177cb1) instead of a SemVer or pseudo-version; run `go
get github.com/openshift/hive/apis@afd410177cb1` to resolve and record the
generated pseudo-version, then commit the updated go.mod (and updated vendor
metadata/modules.txt if you vendor) so the module requirement is a valid Go
pseudo-version rather than a raw hash.
In `@go.mod`:
- Line 62: The go.mod entry for github.com/openshift/hive/apis currently uses a
raw SHA suffix ("afd410177cb1"); replace it with a proper pseudo-version by
running: go get github.com/openshift/hive/apis@afd410177cb1 to update go.mod
(this will convert the raw SHA into a pseudo-version for the module), then run
go mod tidy and go mod vendor to synchronize vendor/modules.txt; ensure the
updated go.mod contains the pseudo-version for github.com/openshift/hive/apis
and that vendor/modules.txt reflects the change.
ℹ️ Review info
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
api/go.modgo.mod
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/hive-api-synchronization
branch
from
f82bbd5 to
37598f9
Compare
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/hive-api-synchronization
branch
from
37598f9 to
de38380
Compare
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
deleted the
konflux/mintmaker/master/hive-api-synchronization
branch
red-hat-konflux
Bot
changed the title
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/hive-api-synchronization
branch
from
de38380 to
6917456
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/master/hive-api-synchronization
branch
from
6917456 to
16c7262
Compare
red-hat-konflux
Bot
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
closed because of the wrong version format |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
2 participants
This PR contains the following updates:
e33d703->3ea8a7fad99b9e->3ea8a7fConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.