Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions projects/fine_tuning/testing/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,7 @@ ci_presets:
tests.fine_tuning.matbenchmarking.stop_on_error: false
tests.fine_tuning.test_settings.name: qlora
tests.fine_tuning.test_settings.model_name:
- rhoai/mistral-7b-v0.3-gptq
- rhoai/granite-8b-code-instruct-gptq
- rhoai/allam-beta-13b-chat-gptq
- rhoai/granite-34b-code-base-gptq
- rhoai/mixtral-8x7b-instruct-v0.1-gptq
- rhoai/llama-3.1-405b-gptq
tests.fine_tuning.test_settings.dataset_name: alpaca_data.json
tests.fine_tuning.test_settings.dataset_replication: 0.2
tests.fine_tuning.test_settings.gpu: 8
Expand Down Expand Up @@ -423,7 +418,7 @@ gpu:
replicas: 1

fine_tuning:
image: quay.io/modh/fms-hf-tuning:v2.0.1
image: quay.io/modh/fms-hf-tuning:v2.1.0
pvc:
name: fine-tuning-storage
access_mode: ReadWriteOnce
Expand Down
2 changes: 2 additions & 0 deletions projects/fine_tuning/testing/prepare_finetuning.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def prepare_gpu():


def prepare_rhoai():
return
if not PSAP_ODS_SECRET_PATH.exists():
raise RuntimeError(f"Path with the secrets (PSAP_ODS_SECRET_PATH={PSAP_ODS_SECRET_PATH}) does not exists.")

Expand Down Expand Up @@ -68,6 +69,7 @@ def prepare_rhoai():


def set_namespace_annotations():
return
metal = config.project.get_config("clusters.sutest.is_metal")
dedicated = config.project.get_config("clusters.sutest.compute.dedicated")
namespace = config.project.get_config("tests.fine_tuning.namespace")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ spec:
mountPath: /mnt/entrypoint
- name: config-volume
mountPath: /mnt/config
- name: output-volume
- name: scratch-volume
mountPath: /mnt/output
resources:
requests: &request_block
Expand All @@ -87,8 +87,17 @@ spec:
- name: entrypoint-volume
configMap:
name: {{ job_name_safe }}-entrypoint
- name: output-volume
emptyDir: {}
# - name: output-volume
# emptyDir: {}
- name: scratch-volume
ephemeral:
volumeClaimTemplate:
metadata:
spec:
accessModes: [ "ReadWriteOnce" ]
resources:
requests:
storage: 500Gi
{% if fine_tuning_run_fine_tuning_job_worker_replicas > 0 %}
Worker:
replicas: {{ fine_tuning_run_fine_tuning_job_worker_replicas }}
Expand Down
6 changes: 3 additions & 3 deletions projects/local_ci/testing/config.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
base_image:
namespace: topsail
namespace: rhoai-tuning-test
imagestream: topsail
repo:
url: https://github.com/openshift-psap/topsail/
ref: main
dockerfile_path: build/Dockerfile
user:
service_account: topsail
role: cluster-admin
service_account: rhoai-tuning-test-sa
role: rhoai-tuning-test-admin-role
secrets:
psap-ods-secret:
env_key: PSAP_ODS_SECRET_PATH
Expand Down
4 changes: 2 additions & 2 deletions projects/local_ci/testing/run
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ def local_ci_prepare():
# Prepare the ServiceAccount
#

run.run(f"oc create serviceaccount {service_account} -n {namespace} --dry-run=client -oyaml | oc apply -f-")
run.run(f"oc adm policy add-cluster-role-to-user {role} -z {service_account} -n {namespace}")
# run.run(f"oc create serviceaccount {service_account} -n {namespace} --dry-run=client -oyaml | oc apply -f-")
# run.run(f"oc adm policy add-cluster-role-to-user {role} -z {service_account} -n {namespace}")

#
# Prepare the Secrets
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ spec:
subPath: entrypoint.sh
- name: storage
mountPath: /storage
serviceAccount: rhoai-tuning-test-sa
serviceAccountName: rhoai-tuning-test-sa
volumes:
{% if storage_download_to_pvc_creds | length %}
- name: download-secret
Expand Down