OCPBUGS-83865: Add MC to change stalld backend#757
Conversation
|
@bartwensley: This pull request references Jira Issue OCPBUGS-83865, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bartwensley: This pull request references Jira Issue OCPBUGS-83865, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (10)
✅ Files skipped from review due to trivial changes (6)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis change introduces stalld-backend service configuration for OpenShift cluster nodes. A Bash build script uses Changesstalld-backend Configuration
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@telco-ran/configuration/extra-manifests-builder/11-stalld-backend/build.sh`:
- Around line 8-10: The shell invocation uses unquoted variable expansions
(${MCMAKER} and ${MCPROLE}) which can cause word-splitting/globbing errors;
update the command in build.sh to quote these expansions (use "${MCMAKER}" and
"${MCPROLE}") wherever they are passed to the command (the line invoking MCMAKER
-name 11-stalld-backend -mcp ${MCPROLE} -stdout ...) and apply the identical
change to the other occurrence in
01-container-mount-ns-and-kubelet-conf/build.sh (the -mcp ${MCPROLE} invocation)
so all variable uses are safely quoted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: e71f296c-8e3c-46b5-846c-78127f7eede7
📒 Files selected for processing (5)
telco-ran/configuration/extra-manifests-builder/11-stalld-backend/build.shtelco-ran/configuration/extra-manifests-builder/11-stalld-backend/stalld-backendtelco-ran/configuration/extra-manifests-builder/11-stalld-backend/stalld-backend.conftelco-ran/configuration/source-crs/extra-manifest/11-stalld-backend-master.yamltelco-ran/configuration/source-crs/extra-manifest/11-stalld-backend-worker.yaml
Adding an MC to revert the stalld backend to sched_debug. This is necessary because the new default queue_task backend causes an unacceptable latency penalty (see RHEL-175242). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Bart Wensley <bwensley@redhat.com>
bartwensley
force-pushed
the
stalld-backend
branch
from
8eee90d to
1e0e48a
Compare
|
/lgtm |
|
@bartwensley The config file generator stuff is a lot of files indeed. Btw, why not include this into NTO directly? I would say this is something the customers should not care about. |
I hadn't considered using NTO - I will take a look at that option now. /hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/cc @makelinux |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bartwensley, makelinux The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I have created a PR to do this in the cluster-node-tuning-operator instead: openshift/cluster-node-tuning-operator#1515 |
5 participants
Adding an MC to revert the stalld backend to sched_debug. This is necessary because the new default queue_task backend causes an unacceptable latency penalty (see RHEL-175242).