OCPBUGS-59292: telco-core: monitoring label in kube compare reference#616
Conversation
|
@abraham2512: This pull request references Jira Issue OCPBUGS-59292, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@abraham2512: This pull request references Jira Issue OCPBUGS-59292, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@abraham2512: This pull request references Jira Issue OCPBUGS-59292, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@abraham2512: This pull request references Jira Issue OCPBUGS-59292, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| kind: Namespace | ||
| metadata: | ||
| labels: | ||
| name: openshift-nmstate |
There was a problem hiding this comment.
Why is the name label needed here?
There was a problem hiding this comment.
Thanks, I've removed it from this PR. It was a shown as a diff in the bug description, but I dont see other Namespace CRs having this in the reference template.
If metadata.labels.name is a diff, it should be under fieldsToOmit in metadata.yaml
Maybe I can add that in a follow up if needed?
abraham2512
force-pushed
the
monitoring-label
branch
from
d54e72b to
0bd5a51
Compare
abraham2512
force-pushed
the
monitoring-label
branch
from
0bd5a51 to
afa6c95
Compare
|
/cc @lack |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abraham2512, lack The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@abraham2512: Jira Issue OCPBUGS-59292: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-59292 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
Tolerate cluster monitoring label in kube compare reference NMState crs