Skip to content

OCPBUGS-77091: Add ts2phc.pin_index 1 to ptpconfigs#597

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-kni:mainfrom
nocturnalastro:fix_ts2phc_config
Apr 2, 2026
Merged

OCPBUGS-77091: Add ts2phc.pin_index 1 to ptpconfigs#597
openshift-merge-bot[bot] merged 1 commit intoopenshift-kni:mainfrom
nocturnalastro:fix_ts2phc_config

Conversation

@nocturnalastro
Copy link
Copy Markdown
Contributor

A driver has made it so the default value (0) for the pin_index is no longer valid instead it must be set to 1 for ts2phc to function

A driver has made it so the default value (0) for the pin_index is no longer valid instead it
must be set to 1 for ts2phc to function
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 23, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2026
@nocturnalastro nocturnalastro changed the title Add ts2phc.pin_index 1 to ptpconfigs OCPBUGS-77091: Add ts2phc.pin_index 1 to ptpconfigs Feb 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@nocturnalastro: This pull request references Jira Issue OCPBUGS-77091, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @dpopsuev

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

A driver has made it so the default value (0) for the pin_index is no longer valid instead it must be set to 1 for ts2phc to function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 23, 2026

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: dpopsuev.

Note that only openshift-kni members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@nocturnalastro: This pull request references Jira Issue OCPBUGS-77091, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @dpopsuev

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

A driver has made it so the default value (0) for the pin_index is no longer valid instead it must be set to 1 for ts2phc to function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nocturnalastro nocturnalastro marked this pull request as ready for review February 24, 2026 12:12
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack, nocturnalastro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 4fa266a into openshift-kni:main Apr 2, 2026
3 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@nocturnalastro: Jira Issue OCPBUGS-77091 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

A driver has made it so the default value (0) for the pin_index is no longer valid instead it must be set to 1 for ts2phc to function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants