Skip to content

Ocpbugs-67196 cluster network mtu setting at deployment time #596

Open
elhadjici wants to merge 4 commits intoopenshift-kni:mainfrom
elhadjici:OCPBUGS-67196-spoke-mtu-setting
Open

Ocpbugs-67196 cluster network mtu setting at deployment time #596
elhadjici wants to merge 4 commits intoopenshift-kni:mainfrom
elhadjici:OCPBUGS-67196-spoke-mtu-setting

Conversation

@elhadjici
Copy link
Copy Markdown

This PR is for setting cluster network MTU at deployment time for Spoke cluster. This is needed for uses case where partner would avoid MTU migration in day2 (minimum 2 reboot) and prefer to set the recommended default cluster network mtu or to set a buffer for MTU for future needs.

@openshift-ci openshift-ci Bot requested review from ffromani and lack February 18, 2026 14:26
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elhadjici
Once this PR has been reviewed and has the lgtm label, please assign lack for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 18, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Feb 18, 2026

Hi @elhadjici. Thanks for your PR.

I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@imiller0
Copy link
Copy Markdown
Collaborator

imiller0 commented Apr 3, 2026

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2026
Comment thread telco-core/install/extra-manifests/Network.yaml Outdated
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1a0ec085-216d-420f-84ad-8507bce1dc34

📥 Commits

Reviewing files that changed from the base of the PR and between dce2c0f and eb99875.

📒 Files selected for processing (1)
  • telco-core/install/extra-manifests/Network.yaml

📝 Walkthrough

Walkthrough

A new OpenShift Operator manifest file was added to configure the cluster's default network. The manifest defines a Network resource for OVN Kubernetes with a maximum transmission unit (MTU) set to 8900 bytes and includes deployment-related annotations.

Changes

Cohort / File(s) Summary
OpenShift Network Configuration
telco-core/install/extra-manifests/Network.yaml
New optional manifest defining a cluster Network resource configured with OVN Kubernetes CNI and MTU value of 8900.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically references the main change: setting cluster network MTU at deployment time for spoke clusters, directly matching the changeset which adds a Network manifest for MTU configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of setting cluster network MTU at deployment time to avoid day-2 migration costs, which matches the Network.yaml manifest addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants