Skip to content

fix(docs): add Stop hook to lifecycle placement table#79

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
brandisher:fix/lifecycle-table-stop-hook
Apr 23, 2026
Merged

fix(docs): add Stop hook to lifecycle placement table#79
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom
brandisher:fix/lifecycle-table-stop-hook

Conversation

@brandisher
Copy link
Copy Markdown
Contributor

@brandisher brandisher commented Apr 23, 2026

Summary

Test plan

  • Verify CONTRIBUTING.md passes markdownlint
  • Confirm the new row accurately reflects the registered Stop hook in .claude/settings.json

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated contribution guidelines with session-end checkpoint specifications for code quality enforcement procedures.

The lifecycle table documented SessionStart and PreToolUse/PostToolUse
stages but omitted Stop, which has an active repo-level hook
(scripts/lint-markdown.sh) for markdown linting.

Addresses post-merge feedback on PR #77.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c571723b-c549-4286-b64d-5f7fd2afaaaa

📥 Commits

Reviewing files that changed from the base of the PR and between 094e6c8 and 6175382.

📒 Files selected for processing (1)
  • CONTRIBUTING.md

Walkthrough

Documentation update to contribution guidance adding a session-end checkpoint specification. The change clarifies that markdown linting and cleanup tasks should be implemented via a repo-level Stop hook, extending the existing hook placement guidance.

Changes

Cohort / File(s) Summary
Documentation
CONTRIBUTING.md
Added session-end protection checkpoint details specifying repo-level Stop hook usage for markdown linting and cleanup tasks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix(docs): add Stop hook to lifecycle placement table' directly matches the main change: adding a missing Stop stage row to the lifecycle table in CONTRIBUTING.md documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@fonta-rh fonta-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — accurately documents the existing Stop hook for markdown linting that was missing from the lifecycle table. Thanks for the quick turnaround on the feedback.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brandisher, fonta-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brandisher,fonta-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 16ab0d5 into openshift-eng:main Apr 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants