Skip to content

Upgrade org.ldaptive:ldaptive from 1.2.3 to 2.3.2#5933

Draft
cwperks wants to merge 4 commits intoopensearch-project:mainfrom
cwperks:upgrade-ldap
Draft

Upgrade org.ldaptive:ldaptive from 1.2.3 to 2.3.2#5933
cwperks wants to merge 4 commits intoopensearch-project:mainfrom
cwperks:upgrade-ldap

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Jan 30, 2026

Description

Upgrade org.ldaptive:ldaptive from 1.2.3 to 2.3.2

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Issues Resolved

Related to: #2959

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Comment on lines +308 to +310
jvmArgs += "--add-opens=java.base/java.nio=ALL-UNNAMED"
jvmArgs += "--add-opens=java.base/sun.nio.ch=ALL-UNNAMED"
jvmArgs += "-Dio.netty.transport.noNative=true"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to fix JDK 25 failures from https://productionresultssa13.blob.core.windows.net/actions-results/976a235c-0711-4a54-a0d8-2c07ccb05d97/workflow-job-run-bace64fb-7753-5237-83f3-6a1d860bd25c/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-01-30T23%3A42%3A38Z&sig=l7SeTIKMS1Rbeyf0VQcyb1zCZQ3OYM%2B7dHZLW3ZYOXE%3D&ske=2026-01-31T00%3A51%3A16Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-01-30T20%3A51%3A16Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-01-30T23%3A32%3A33Z&sv=2025-11-05.:

2026-01-30T23:25:23.2800918Z   2> java.lang.UnsupportedOperationException: Cannot clean arbitrary ByteBuffer instances
2026-01-30T23:25:23.2801195Z   2> 	at __randomizedtesting.SeedInfo.seed([A1DB2CBBF6757983]:0)
2026-01-30T23:25:23.2801662Z   2> 	at io.netty.util.internal.CleanerJava25.freeDirectBuffer(CleanerJava25.java:183)
2026-01-30T23:25:23.2802245Z   2> 	at io.netty.util.internal.PlatformDependent.freeDirectBuffer(PlatformDependent.java:613)
2026-01-30T23:25:23.2803108Z   2> 	at io.netty.channel.unix.Buffer.free(Buffer.java:36)
2026-01-30T23:25:23.2803767Z   2> 	at io.netty.channel.epoll.EpollEventArray.free(EpollEventArray.java:94)
2026-01-30T23:25:23.2804311Z   2> 	at io.netty.channel.epoll.EpollEventLoop.cleanup(EpollEventLoop.java:540)
2026-01-30T23:25:23.2804993Z   2> 	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:1269)
2026-01-30T23:25:23.2827748Z   2> 	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
2026-01-30T23:25:23.2828977Z   2> 	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
2026-01-30T23:25:23.2829893Z   2> 	at java.base/java.lang.Thread.run(Thread.java:1474)
2026-01-30T23:25:23.2830144Z 
2026-01-30T23:25:23.2832372Z   2> com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=265, name=ldaptive-SingleThread@122071539-io-7-1, state=RUNNABLE, group=TGRP-LdapBackendIntegTest2]
2026-01-30T23:25:23.2833391Z         at __randomizedtesting.SeedInfo.seed([A1DB2CBBF6757983:D6934DCC75229F77]:0)
2026-01-30T23:25:23.2833412Z 
2026-01-30T23:25:23.2833627Z         Caused by:
2026-01-30T23:25:23.2834497Z         java.lang.UnsupportedOperationException: Cannot clean arbitrary ByteBuffer instances
2026-01-30T23:25:23.2834958Z             at __randomizedtesting.SeedInfo.seed([A1DB2CBBF6757983]:0)
2026-01-30T23:25:23.2835741Z             at io.netty.util.internal.CleanerJava25.freeDirectBuffer(CleanerJava25.java:183)
2026-01-30T23:25:23.2836711Z             at io.netty.util.internal.PlatformDependent.freeDirectBuffer(PlatformDependent.java:613)
2026-01-30T23:25:23.2837007Z             at io.netty.channel.unix.Buffer.free(Buffer.java:36)
2026-01-30T23:25:23.2837505Z             at io.netty.channel.epoll.EpollEventArray.free(EpollEventArray.java:94)
2026-01-30T23:25:23.2838064Z             at io.netty.channel.epoll.EpollEventLoop.cleanup(EpollEventLoop.java:540)
2026-01-30T23:25:23.2838707Z             at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:1269)
2026-01-30T23:25:23.2839121Z             at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
2026-01-30T23:25:23.2839679Z             at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
2026-01-30T23:25:23.2839970Z             at java.base/java.lang.Thread.run(Thread.java:1474)

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 78.52761% with 70 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.71%. Comparing base (e842cd2) to head (ac2a5f8).

Files with missing lines Patch % Lines
...ty/auth/ldap/backend/LDAPAuthorizationBackend.java 75.38% 9 Missing and 23 partials ⚠️
...urity/auth/ldap2/LDAPConnectionFactoryFactory.java 75.00% 17 Missing and 9 partials ⚠️
...security/auth/ldap2/LDAPAuthorizationBackend2.java 73.68% 4 Missing and 1 partial ⚠️
...y/auth/ldap/backend/LDAPAuthenticationBackend.java 84.00% 3 Missing and 1 partial ⚠️
...ecurity/auth/ldap2/LDAPAuthenticationBackend2.java 86.95% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5933      +/-   ##
==========================================
- Coverage   73.83%   73.71%   -0.13%     
==========================================
  Files         439      438       -1     
  Lines       26884    26635     -249     
  Branches     3980     3915      -65     
==========================================
- Hits        19851    19634     -217     
- Misses       5148     5177      +29     
+ Partials     1885     1824      -61     
Files with missing lines Coverage Δ
...opensearch/security/auth/ldap/util/LdapHelper.java 88.00% <100.00%> (+4.12%) ⬆️
.../org/opensearch/security/auth/ldap/util/Utils.java 65.00% <ø> (-4.24%) ⬇️
...ensearch/security/auth/ldap2/LDAPUserSearcher.java 86.44% <100.00%> (+0.47%) ⬆️
.../org/opensearch/security/support/PemKeyReader.java 71.07% <100.00%> (+0.24%) ⬆️
...earch/security/support/SafeSerializationUtils.java 86.66% <ø> (ø)
...ecurity/auth/ldap2/LDAPAuthenticationBackend2.java 80.00% <86.95%> (-1.02%) ⬇️
...y/auth/ldap/backend/LDAPAuthenticationBackend.java 84.73% <84.00%> (-2.47%) ⬇️
...security/auth/ldap2/LDAPAuthorizationBackend2.java 48.81% <73.68%> (-0.40%) ⬇️
...urity/auth/ldap2/LDAPConnectionFactoryFactory.java 70.12% <75.00%> (+9.98%) ⬆️
...ty/auth/ldap/backend/LDAPAuthorizationBackend.java 80.92% <75.38%> (+13.16%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant