Skip to content

Add gradle.properties file to build performance-analyzer with -Pcrypto.standard=FIPS=140-3 by default#924

Open
cwperks wants to merge 5 commits intoopensearch-project:mainfrom
cwperks:fips-property
Open

Add gradle.properties file to build performance-analyzer with -Pcrypto.standard=FIPS=140-3 by default#924
cwperks wants to merge 5 commits intoopensearch-project:mainfrom
cwperks:fips-property

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Mar 13, 2026

Description

Inspired by opensearch-project/ml-commons#4719, this PR adds a gradle.properties file so that we only need to declare -Pcrypto.standard=FIPS-140-3 in a single place. Now its not necessary to pass the build param in commands like ./gradlew assemble -Pcrypto.standard=FIPS-140-3 as it passes the arg by default.

In order to build without the flag, you would need to override like so: ./gradlew assemble -Pcrypto.standard=any-supported

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Refactoring

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…o.standard=FIPS=140-3 by default

Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks added 2 commits March 13, 2026 13:03
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.48%. Comparing base (9cb092f) to head (b987eb8).
⚠️ Report is 55 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #924      +/-   ##
============================================
- Coverage     70.88%   70.48%   -0.40%     
- Complexity      421      525     +104     
============================================
  Files            49       56       +7     
  Lines          3125     3663     +538     
  Branches        194      244      +50     
============================================
+ Hits           2215     2582     +367     
- Misses          785      918     +133     
- Partials        125      163      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cwperks added 2 commits March 26, 2026 09:32
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant