Add gradle.properties file to build performance-analyzer with -Pcrypto.standard=FIPS=140-3 by default#924
Open
cwperks wants to merge 5 commits intoopensearch-project:mainfrom
Open
Add gradle.properties file to build performance-analyzer with -Pcrypto.standard=FIPS=140-3 by default#924cwperks wants to merge 5 commits intoopensearch-project:mainfrom
cwperks wants to merge 5 commits intoopensearch-project:mainfrom
Conversation
…o.standard=FIPS=140-3 by default Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #924 +/- ##
============================================
- Coverage 70.88% 70.48% -0.40%
- Complexity 421 525 +104
============================================
Files 49 56 +7
Lines 3125 3663 +538
Branches 194 244 +50
============================================
+ Hits 2215 2582 +367
- Misses 785 918 +133
- Partials 125 163 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inspired by opensearch-project/ml-commons#4719, this PR adds a gradle.properties file so that we only need to declare
-Pcrypto.standard=FIPS-140-3in a single place. Now its not necessary to pass the build param in commands like./gradlew assemble -Pcrypto.standard=FIPS-140-3as it passes the arg by default.In order to build without the flag, you would need to override like so:
./gradlew assemble -Pcrypto.standard=any-supportedRefactoring
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.