Add mappings and settings with json#985
Open
JM-Lab wants to merge 1 commit intoopensearch-project:mainfrom
Open
Add mappings and settings with json#985JM-Lab wants to merge 1 commit intoopensearch-project:mainfrom
JM-Lab wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Jemin Huh <hjm1980@gmail.com>
JM-Lab
requested review from
Bukhtawar,
VachaShah,
dblock,
madhusudhankonda,
reta,
saratvemulapalli and
szczepanczykd
as code owners
reta
requested changes
May 14, 2024
| } | ||
|
|
||
| private <T> T deserialize(JsonpDeserializer<T> deserializer, String json) { | ||
| JsonpMapper jsonpMapper = new JacksonJsonpMapper(); |
Collaborator
There was a problem hiding this comment.
This is not going to work, the JsonpMapper is provided by the user when OpenSearchClient instance is created, it has to be respected.
Collaborator
|
Please refer to #257 , the client would benefit from generalized approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to use JSON for mappings and settings in CreateIndexRequest.
This makes it easier for developers to create indices.
Issues Resolved
Fixes #302
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.