Remove default codec and require codec for sqs sink #6486
+10
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
OSversion
branch
from
43f759b to
2e96d82
Compare
graytaylor0
changed the title
dlvenable
reviewed
Feb 5, 2026
| } else { | ||
| codecPluginSettings = new PluginSetting("ndjson", Map.of()); | ||
| String codecPluginName = codecConfiguration.getPluginName(); | ||
| if (!codecPluginName.equals("json") && !codecPluginName.equals("ndjson")) { |
Member
There was a problem hiding this comment.
We should allow for other codecs. I think the only time we want to be restrictive on the codec is when the customer is not using batching (ie. max_events_per_batch == 1). In that case, ndjson should be the only permissible codec.
Customers may want to serialize in Ion, XML, or other codecs.
| @AssertTrue(message = "ndjson codec doesn't support max events per message greater than 1") | ||
| boolean isValidCodecConfig() { | ||
| if ((codec == null || codec.getPluginName().equals("ndjson")) && thresholdConfig.getMaxEventsPerMessage() > 1) | ||
| if ((codec != null && codec.getPluginName().equals("ndjson")) && thresholdConfig.getMaxEventsPerMessage() > 1) |
Member
There was a problem hiding this comment.
I also think it is acceptable to use ndjson with more than one event per message.
I think this is the key condition we want to return false or invalid for.
if ((codec != null && !codec.getPluginName().equals("ndjson")) && thresholdConfig.getMaxEventsPerMessage() == 1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SQS sink has default values that are invalid and throw an InvalidPluginConfigurationException. The combination of defaults with codec
ndjsonandthreshold.max_events_per_messageat 25 are invalid together.Changing the require codec makes it more clear to users what codec is being used and aligns more closely with other data prepper plugins, and does not throw unexpected validation exceptions from defaults.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.