Add Pattern API with opt-in Re2J support #6478
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Pattern interface in data-prepper-api - Add Re2J implementation with ServiceLoader - Update all processors to use Pattern API - Add Re2J tests to verify adversarial pattern protection - Default to Java SDK Pattern for backward compatibility Resolves opensearch-project#6279 Signed-off-by: Arvind Maan <arvindsmaan@gmail.com>
Arvind-Maan
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates an overridable Pattern interface in data-prepper-api that allows consumers to set the Pattern library used for regex evaluation through System environment field
dataprepper.pattern.provider. By default, it will fallback to the Java SDK regex library (the current one), unless set in the system. Updates the corresponding modules that leverage Pattern to use the new Pattern interface.Additionally, this CR creates a Pattern Provider leveraging the Re2j library, which works to minimize the risk of adversarial regex's directly resolving #6279
Issues Resolved
Resolves #6279
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.