Fix delete_source removing parsed field when writing to root in parse…#6443
Open
DayneD89 wants to merge 1 commit intoopensearch-project:mainfrom
Open
Fix delete_source removing parsed field when writing to root in parse…#6443DayneD89 wants to merge 1 commit intoopensearch-project:mainfrom
DayneD89 wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
… JSON processor When source field name matches a key in the parsed JSON and delete_source is true with destination set to root (the default), the source was deleted after writeToRoot(), removing the parsed value instead of the original. Now deletes source before writeToRoot() when writing to root. Signed-off-by: DayneD89 <DayneD89@gmail.com>
DayneD89
requested review from
KarstenSchnitter,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Author
No problem, tbf it's because I need it fixed so it's selfishness really. What's your process for bringing this in? Do I need to do anything or leave it with you and wait for a release with it in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… JSON processor
When source field name matches a key in the parsed JSON and delete_source is true with destination set to root (the default), the source was deleted after writeToRoot(), removing the parsed value instead of the original. Now deletes source before writeToRoot() when writing to root.
Description
Fixes an oversight in the parse_json processor where if processing a json with a field value matching
sourcefield anddelete_sourceset to true causes the added field to be removed.Issues Resolved
I haven't opened a ticket, the contribution guide says 'You open an issue to discuss any significant work - we would hate for your time to be wasted.' and I don't consider this a significant change?
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.