add ui metadata in workflow object#458
Open
eirsep wants to merge 1 commit intoopensearch-project:mainfrom
Open
add ui metadata in workflow object#458eirsep wants to merge 1 commit intoopensearch-project:mainfrom
eirsep wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
eirsep
requested review from
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
lezzago,
qreshi,
rishabhmaurya,
sbcd90 and
tlfeng
as code owners
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
============================================
- Coverage 73.78% 73.76% -0.03%
- Complexity 819 820 +1
============================================
Files 126 126
Lines 5341 5348 +7
Branches 675 676 +1
============================================
+ Hits 3941 3945 +4
- Misses 1103 1104 +1
- Partials 297 299 +2
|
lezzago
changed the title
Member
|
There has been talks about going away from this logic since if someone creates the monitor/workflow through the api, it can never be converted to the visual mode even if the visual mode would support that configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ui metadata in worklfow object similar to ui metadata object present in monitor. this is required for dashboards to store metadata information