Create WaitForClusterSetup gradle plugin to abstract common logic across multiple plugins#18892
Create WaitForClusterSetup gradle plugin to abstract common logic across multiple plugins#18892cwperks wants to merge 4 commits intoopensearch-project:mainfrom
Conversation
…oss multiple plugins Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
@epugh you may be interested in this one. This has been on my TODO list for a while...I will create a PR on the search-relevance repo after this is merged. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
Thanks for this change @cwperks, seeing this PR opensearch-project/reporting#1111 lot of code is removed by using this plugin. Will review this PR soon. |
|
❌ Gradle check result for ce6d933: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 2f9a184: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18892 +/- ##
============================================
+ Coverage 72.77% 72.81% +0.04%
- Complexity 68690 68819 +129
============================================
Files 5582 5590 +8
Lines 315456 315796 +340
Branches 45778 45827 +49
============================================
+ Hits 229568 229952 +384
+ Misses 67290 67233 -57
- Partials 18598 18611 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for doing this. There is way too much boiler plate code that gets copied from plugin repo to plugin repo! |
|
This PR is stalled because it has been open for 30 days with no activity. |
|
Closing as this is already possible in testclusters by passing the following system props: |
Description
Many plugins have the following logic copied to help setting up integTests running with security: https://github.com/search?q=org%3Aopensearch-project%20%22def%20waitForClusterSetup%22&type=code
The reason for the logic is to configure the protocol (http:// vs https://) and then also configured username and password for configuring basic auth authentication which is the predominant type of auth using for automated testing across the plugins. (The security repo has tests that run with many other auth types, but for plugins they exclusively test with basic auth for testing integration with security)
Tested by publishing these changes and run on the reporting repo. See opensearch-project/reporting#1111 for testing details.
Related Issues
Resolves opensearch-project/opensearch-plugins#245
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.