Migrate deprecated AssertionsForClassTypes/InterfaceTypes to Assertions#1010
Merged
Conversation
…tions AssertJ deprecated `AssertionsForClassTypes` and `AssertionsForInterfaceTypes` in favor of the unified `Assertions` entry point (assertj/assertj#4268). This adds `MigrateAssertionsForClassAndInterfaceTypes`, which retargets all static methods of both classes to `Assertions`. The generic `AssertionsForClassTypes.assertThat(T)` returns an `ObjectAssert`, but the unified `Assertions` also offers more specific overloads, so a naive swap would re-bind an `Iterable`/`Map`/`Comparable`/... argument to e.g. `IterableAssert` and stop compiling. The new type-aware `MigrateAssertionsForClassTypes` recipe routes only those colliding arguments to `assertThatObject`, resolving #664.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssertJ deprecated
AssertionsForClassTypesandAssertionsForInterfaceTypesin favor of the unifiedAssertionsentry point (assertj/assertj#4268), so this addsMigrateAssertionsForClassAndInterfaceTypesto retarget all static methods of both classes toAssertions(enabling the long-disabled handling from Code does not compile after AssertionsForClassTypes import is replaced by Assertions #664). The hazard is the genericAssertionsForClassTypes.assertThat(T)(returnsObjectAssert): sinceAssertionsalso has more-specific overloads, a naive swap would re-bind anIterable/Map/Comparable/... argument to e.g.IterableAssertand stop compiling. The new type-awareMigrateAssertionsForClassTypesrecipe routes only those colliding arguments toassertThatObject, leaving plain objects and typed overloads onassertThat. The recipe is wired into the top-levelAssertjrecipe, the superseded@DisabledStaticImportsTestcase is replaced by a dedicated test class, andrecipes.csvis updated. Everything is verified against AssertJ 3.27 (all migration targets already exist), so it works today even though the upstream PR is still a draft targeting 3.28.0.Fixes Code does not compile after AssertionsForClassTypes import is replaced by Assertions #664