fix: do not replace lambda params with underscore when used as assignment target#1117
Merged
timtebeek merged 1 commit intoMay 28, 2026
Conversation
timtebeek
approved these changes
May 28, 2026
Member
timtebeek
left a comment
timtebeek
left a comment
There was a problem hiding this comment.
Thanks for the immediate fix! Looks perfect.
github-project-automation
Bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ReplaceUnusedVariablesWithUnderscoreincorrectly renames lambda parameters to_when they appear as LHS assignment targets, producing uncompilable code.Fix
Added
usedAsAssignmentTarget()guard following the same pattern as the existingusedInModifyingUnary()method, and wired it intorenameVariableIfUnusedInContext.Tests
Added three test cases covering:
First param as assignment target, second correctly renamed
Second param as assignment target, first correctly renamed
Single param as assignment target
Fixes ReplaceUnusedVariablesWithUnderscore incorrectly renames lambda params used as assignment targets producing uncompilable code #1116