Skip UseMapOf for HashMap subclasses like LinkedHashMap and TreeMap#1113
Merged
Conversation
…eeMap` `Map.of(..)` does not preserve iteration order, so converting order-sensitive maps silently drops their ordering contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map.of(..)makes no iteration-order guarantee, so converting an order-sensitiveLinkedHashMap(orTreeMap) silently drops the ordering contract callers rely on. TheNEW_HASH_MAPmatcher usedmatchOverrides=trueto catch thenew HashMap<>() {{...}}anonymous-subclass idiom, which also caused it to match non-anonymousHashMapsubclasses. Added aTypeUtils.isOfClassTypecheck on the declared class so onlyjava.util.HashMapis rewritten, with regression tests forLinkedHashMapandTreeMap.