Skip UseTextBlocks when literal value matches its source#1111
Merged
Conversation
Defend against `J.Literal` values that come back identical to their `valueSource` (observed for string literals containing supplementary characters encoded as surrogate pairs). Skipping the conversion avoids emitting a broken text block that drops or re-escapes content. Fixes #1110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UseTextBlockswas emitting broken text blocks for string literals containing supplementary characters encoded as surrogate pairs (e.g."𝄠"), dropping the character and re-escaping content.Root cause: the Java parser returns a corrupted
J.Literalfor these literals, wherevalueequalsvalueSource(both stripped of the surrogate pair). The recipe then treated that quoted source form as content.Fix: bail out of the conversion when
value.equals(valueSource); that condition is impossible for a correctly decoded string literal, so it's a safe sentinel for parser corruption.Fixes UseTextBlocks drops supplementary characters encoded as surrogate pairs and emits invalid output #1110
Test plan
supplementaryCharacterAsSurrogatePairasserting the recipe leaves the original concatenation unchanged.UseTextBlocksTestsuite passes.