Iterate peers as linked list instead of array#65
Open
quezacoatl wants to merge 1 commit intoopenresty:masterfrom
Open
Iterate peers as linked list instead of array#65quezacoatl wants to merge 1 commit intoopenresty:masterfrom
quezacoatl wants to merge 1 commit intoopenresty:masterfrom
Conversation
Author
|
I got this reply when I asked regarding this in nginx-devel mailing list: The ngx_lua_upstream module is not adapted to work with peers stored See this change as a guidance: |
Accessing peers as an array has been deprecated since nginx 1.9.0 (changeset 6100 - http://hg.nginx.org/nginx/rev/c44459611d91) and does not work when using the "zone" directive in upstream. This commit changes iteration to use peer->next and iterate as a linked list.
quezacoatl
force-pushed
the
peers-as-linked-list
branch
from
6a9cffe to
25a918c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing peers as an array has been deprecated since nginx 1.9.0 (changeset 6100 - http://hg.nginx.org/nginx/rev/c44459611d91) and does not work when using the
zonedirective inupstreamblock. This commit changes iteration to usepeer->nextand iterate as a linked list.This PR should solve #31 and #61