Hi,I pull a request for add_server to upstream,and include testing code

[chunshengster]

Hi,agentzh , I have add a function for add_server() ,and made some test under Test::Nginx . Pls review the code ,and thx.

[chunshengster]

sorry for this pr, I have not test weather the added server can take effect in proxy_pass http://bar

[chunshengster]

I think i should write another function named add_peer ,which can add server from uscf->servers to uscf->peer.data,is that right ?

[agentzh]

@chunshengster I'll have a look as soon as I have a chance :) Thanks for working on this.

[subnetmarco]

+1

[agentzh]

@chunshengster Please ensure that your change can work with all the existing balancer modules like least_conn, ip_hash, and etc.

[chunshengster]

Hi,now My team have done this work for all existing banlancer modules , after some time ,I will repull this request ,with some tests.

[esatterwhite]

Has there been any progress here? Would love to see this land.

[agentzh]

@esatterwhite Have you looked at the new balancer_by_lua* directives in the balancer-by-lua github branch?

[esatterwhite]

Is that planned for an up coming release?

[agentzh]

@esatterwhite It's in the public balancer-by-lua github branch of this repos. It'll get included in a future release, but not necessarily in the next release.

You're encouraged to try out that branch to ensure it fits your needs before it is set in the stone.

[hdavid]

hi,
this pull request would be super nice to have. any chances to get it merged ?

[lippertmarkus]

+1