-
Notifications
You must be signed in to change notification settings - Fork 8
NiFTi Conversion APIs #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
8e3086b
adding nifti wador retrieve, view endpoints
chinacat567 14df02d
sync to async
chinacat567 76ec022
adding nifti view urls, sample test
chinacat567 6e4374c
adding multipart boundary
chinacat567 1c2205c
lint fix
chinacat567 6b4ddf8
test fixes
chinacat567 a9726a8
refac for filename and json metadata
chinacat567 699609b
adding test, fixing broken url
chinacat567 40253c2
lint fix
chinacat567 d8bd125
pyproject update
chinacat567 3d00b2a
fixing renderer classes in the view
chinacat567 6aec4b0
adding tests
chinacat567 b0c5215
update for json files
chinacat567 b293e76
lint fix
chinacat567 8106940
removing redundant code
chinacat567 bbfb9e8
fixing redundant code in client.py
chinacat567 1f383fd
fixing nit comment
chinacat567 d6d4b93
refac wador_utils to process a single series during nifti conversion
chinacat567 a50cde1
renaming DICOM_SAMPLE_DIR env variable
chinacat567 f9373e5
removing useless static method
chinacat567 5977968
making file/os functions async
chinacat567 fb5919a
updating yielding logic for json, nifti files
chinacat567 4250007
raise error when content disposition is not present
chinacat567 20c140a
adding iter methods to adit client
chinacat567 0431cc7
co-pilot fixes
chinacat567 27f96f0
env variable fix
chinacat567 8687598
env var fix
chinacat567 0534c66
adding streaming for nifti files
chinacat567 36a364c
fixing fetch task await and expcetion handling in fetch_dicom_data
chinacat567 e4e89b8
using aiofiles temp directory
chinacat567 e88976b
improving dcm2niix exception handling
chinacat567 f312f14
updating wador_utils for SR/invalid files
chinacat567 f0a1dca
env var fix
chinacat567 f41d341
aiofiles fix
chinacat567 0b0b332
use list comprehension
chinacat567 7369f43
adding test settings
chinacat567 c902e49
removing MultipartDecoder for retrieve methods, using _decode_multipa…
chinacat567 b925022
adding tests for iter methods
chinacat567 7edf07c
fixing await pattern on async function
chinacat567 af66b1b
adding bval/bvac files
chinacat567 0295bcc
dicom to nifti fix
chinacat567 ad60d1d
testing
chinacat567 967cd6b
lint fix
chinacat567 25a4846
restoring ci.yml and pyrpoject
chinacat567 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,60 @@ class RetriableDicomError(Exception): | |
| pass | ||
|
|
||
|
|
||
| class DicomConversionError(Exception): | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would here also prefer |
||
| """Base exception for DICOM to NIfTI conversion errors.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class NoValidDicomError(DicomConversionError): | ||
| """Exception raised when no valid DICOM files are found.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class InvalidDicomError(DicomConversionError): | ||
| """Exception raised when DICOM files are invalid or corrupt.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class OutputDirectoryError(DicomConversionError): | ||
| """Exception raised when there are issues with the output directory.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class InputDirectoryError(DicomConversionError): | ||
| """Exception raised when there are issues with the input directory.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class ExternalToolError(DicomConversionError): | ||
| """Exception raised when there are issues with the external dcm2niix tool.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class NoSpatialDataError(DicomConversionError): | ||
| """Exception raised when DICOM data doesn't have spatial attributes.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class NoMemoryError(DicomConversionError): | ||
| """Exception raised when the system runs out of memory during conversion.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class UnknownFormatError(DicomConversionError): | ||
| """Exception raised when input contains unsupported format.""" | ||
|
|
||
| pass | ||
|
|
||
|
|
||
| class BatchFileSizeError(Exception): | ||
| def __init__(self, batch_tasks_count: int, max_batch_size: int) -> None: | ||
| super().__init__("Too many batch tasks.") | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.