Bump Viash version and update dependencies to OpenProblems #32
Conversation
|
Hi @wes-lewis ! We want to trigger a new run of this task. This PR contains a few technical updates to make sure everything runs through. Would you like to review this? Thanks! |
| # generate a unique id | ||
| RUN_ID="run_$(date +%Y-%m-%d_%H-%M-%S)" | ||
| publish_dir="s3://openproblems-data/resources/task_denoising/results/${RUN_ID}" | ||
| publish_dir="s3://openproblems-data/resources/results/${RUN_ID}" |
There was a problem hiding this comment.
I guess you meant to remove the task name from here?
There was a problem hiding this comment.
No, the results need to be published in the task specific subdirs ^^ Coincidentally I had make the same changes but then reverted them because I realised that this in fact made sense
|
@lazappi @rcannood I see that all checks have passed, and am nearly ready to merge. For something like this (some technical updates etc, after a few recent method additions), is there a way to check that the actual results table makes sense and is not hugely different from the previous results before merging? It would be great if there was e.g. a way to render the output figure for a given PR, but I don't know if this exists. Thanks much |
|
Not automatically. We would need to build the components and run the workflow. It's doable but there is time/cost involved so we don't do it by default for every PR (it would be great if we could!). We could maybe look at it if you think it's important for this change. |
|
Understood. No worries in that case--I just wanted to see if there was a way to trigger a run as a triage against any larger errors. This idea is not especially relevant to this PR and thus the PR is ready to merge. |
Update the Viash version to 0.9.4 and change dependencies to use the OpenProblems repository.