Skip to content

Closes #<90> by changing precision#92

Closed
xidongdxi wants to merge 3 commits intomainfrom
90-bug-graph_test_closure-provides-inconsistent-results-between-rejections-and-closed-tests
Closed

Closes #<90> by changing precision#92
xidongdxi wants to merge 3 commits intomainfrom
90-bug-graph_test_closure-provides-inconsistent-results-between-rejections-and-closed-tests

Conversation

@xidongdxi
Copy link
Copy Markdown
Collaborator

Thank you for your Pull Request!

We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the graphicalMCP codebase remains robust and consistent.

Changes Description

Closes #90

R/graph_test_closure.R — added parametric-aware tolerance for rejection comparisons

Task List

This is a list of tasks that can be done by contributors to make reviewing faster and more straightforward. If you're unsure how to do any or all of these, please make your contributions anyway. We are happy to work with you on any of them! However, know that your contributions may be more likely to be accepted, or be accepted more quickly, the more of these you can accomplish. They are roughly sorted in descending order of helpfulness.

  • [X ] Fill out Changes Description above
  • [ X] Update relevant unit tests or write new unit tests
  • [ X] Create/update relevant roxygen headers and examples
  • [ X] Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page
  • [ X] Update NEWS.md with a brief summary of changes made - Note the related issue number(s) at the end like (#000)
  • [ X] Make sure that the package versions in the NEWS.md and DESCRIPTION file are the same
  • [ X] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • [ X] Format code according to the tidyverse style guide (Run styler::style_pkg())
  • [ X] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • [ X] Run codemetar::write_codemeta() to update codemeta.json
  • [ X] Address any updates needed for vignettes and/or templates
  • [ X] Link the issue Development Panel so that the related issue closes after successful merging
  • [ X] Fix merge conflicts
  • [ X] Pat yourself on the back for a job well done! Here's a random cat gif for your hard work :)

@xidongdxi xidongdxi closed this Mar 21, 2026
@xidongdxi xidongdxi deleted the 90-bug-graph_test_closure-provides-inconsistent-results-between-rejections-and-closed-tests branch March 21, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: graph_test_closure() provides inconsistent results between rejections and closed tests

1 participant