Skip to content

926: Implement backfill cohorts simulations#927

Merged
danielinteractive merged 95 commits intomainfrom
danielinteractive/issue926
Jan 30, 2026
Merged

926: Implement backfill cohorts simulations#927
danielinteractive merged 95 commits intomainfrom
danielinteractive/issue926

Conversation

@danielinteractive
Copy link
Copy Markdown
Collaborator

closes #926

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements backfill cohort simulations for phase I dose-escalation studies, addressing issue #926. It introduces comprehensive functionality for managing backfill cohorts including new classes for opening rules, recruitment strategies, and cohort management.

Changes:

  • Added new Backfill, Opening, and Recruitment class hierarchies for managing backfill cohorts
  • Extended Data class with backfilled and response slots to track patient backfill status and efficacy responses
  • Enhanced Design class with backfill support and updated simulation methods
  • Added CohortSizeRandom for random cohort sizes and extended StoppingPatientsNearDose with backfill exclusion option

Reviewed changes

Copilot reviewed 123 out of 168 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vignettes/vignettes.bib Added citation for Barnett et al. 2023 backfilling paper
tests/testthat/test-*.R Comprehensive test coverage for new backfill functionality
R/Backfill-*.R New classes and methods for backfill cohort management
R/Data-*.R Extended Data class with backfill and response tracking
R/Design-*.R Integration of backfill into design and simulation workflows
R/Simulations-*.R Added backfill statistics to simulation summaries
man/*.Rd Documentation for all new classes and methods
examples/*.R Examples demonstrating backfill usage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/testthat/test-Data-methods.R
@pengguanya
Copy link
Copy Markdown
Collaborator

@danielinteractive The URL only exist after merge, that's why the URL check failed. You can comment out the url for now to pass the check and make the url available in main and after merge have another commit to uncomment the url.

@pengguanya
Copy link
Copy Markdown
Collaborator

@danielinteractive I checked your changes. It might be easier to merge my new PR first: #931

Since you need anyway to get rid of URL check error first. If my PR get merged first, I think only additional trouble for you is to resolve conflict in DESCRIPTION and/or NAMESPACE

@danielinteractive
Copy link
Copy Markdown
Collaborator Author

@pengguanya thanks yeah I will see about the order, no worries

@danielinteractive danielinteractive merged commit 68fdcdb into main Jan 30, 2026
22 of 23 checks passed
@danielinteractive danielinteractive deleted the danielinteractive/issue926 branch January 30, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement backfill cohorts simulations

3 participants