Remove "real like" fake test data from documents data#874
Merged
yingbull merged 4 commits intodevelop/dogfishfrom Nov 18, 2025
Merged
Remove "real like" fake test data from documents data#874yingbull merged 4 commits intodevelop/dogfishfrom
yingbull merged 4 commits intodevelop/dogfishfrom
Conversation
…ed references in development.sql with two remaining pdf's that names are instantly recognizable as fake
…ncorporate these additions into the initial test data
…st pdf's into some existing document inserts, added new test data to default provider, with all currently existing document test data
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdate development SQL seed by replacing real-like test PDFs with clearly fake placeholders and expanding document-provider mappings for the openodoc provider. Entity relationship diagram for updated document and ctl_document tableserDiagram
document {
int id PK
varchar doctype
varchar doc_class
varchar doc_subclass
varchar doc_title
varchar doc_desc
varchar filename
int provider_id
}
ctl_document {
varchar entity_type
int entity_id
int document_id
varchar status
}
document ||--o{ ctl_document : "referenced by"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
yingbull
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I have:
I have tested these changes by:
Summary by Sourcery
Clean up test document data by removing realistic fake PDFs and replacing them with intentionally fake ones, updating the development SQL fixtures accordingly.
Enhancements:
Tests: