Skip to content

Fixed 500 error on security log report#683

Merged
yingbull merged 1 commit intodevelop/dogfishfrom
677-security-log-report-errors
Oct 3, 2025
Merged

Fixed 500 error on security log report#683
yingbull merged 1 commit intodevelop/dogfishfrom
677-security-log-report-errors

Conversation

@LiamStanziani
Copy link
Copy Markdown
Collaborator

@LiamStanziani LiamStanziani commented Oct 2, 2025

Fixed 500 error on security log report due to incorrect db table name

Summary by Sourcery

Bug Fixes:

  • Resolve 500 error on security log report by correcting the database table name in SQL queries

@LiamStanziani LiamStanziani self-assigned this Oct 2, 2025
@LiamStanziani LiamStanziani linked an issue Oct 2, 2025 that may be closed by this pull request
2 tasks
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Oct 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updated logReport.jsp SQL queries to use the correct 'provider' table name, resolving 500 errors caused by referencing the non-existent 'providers' table.

Entity Relationship diagram for corrected provider table usage

erDiagram
    PROVIDER {
        int provider_no
        string first_name
        string last_name
        ...
    }
    PROVIDERSITE {
        int provider_no
        int site_id
        ...
    }
    PROVIDER ||--o{ PROVIDERSITE : "has"
Loading

Class diagram for updated SQL query logic in logReport.jsp

classDiagram
    class LogReport {
        +boolean isSiteAccessPrivacy
        +int curUser_no
        +Properties propName
        +ResultSet rs
        +void queryResults(String sql)
    }
    LogReport : +sql (uses 'provider' table)
Loading

File-Level Changes

Change Details Files
Correct SQL table reference to 'provider' to prevent DB errors
  • Use 'provider' instead of 'providers' in site-access query
  • Use 'provider' instead of 'providers' in default query
src/main/webapp/admin/logReport.jsp

Possibly linked issues

  • Fixed the vulnerabilty #123: The PR fixes the 500 error on the reports tab by changing the SQL table name from 'providers' to 'provider' in logReport.jsp.
  • #Bug_Security_Log_Report_errors_when_accessed: PR fixes 500 error on security log report by correcting 'providers' to 'provider' in SQL queries.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 2, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 222ae26.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@LiamStanziani LiamStanziani marked this pull request as ready for review October 2, 2025 16:59
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LiamStanziani LiamStanziani requested a review from yingbull October 2, 2025 17:01
@yingbull yingbull merged commit bdb44de into develop/dogfish Oct 3, 2025
12 of 15 checks passed
@yingbull yingbull deleted the 677-security-log-report-errors branch October 3, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Security Log Report errors when accessed

2 participants