Skip to content

Fix typo in JSON field name to resolve Patient MRP showing as undefined#665

Merged
yingbull merged 1 commit intodevelop/dogfishfrom
bugfix/typo-provider-field-mrp
Oct 1, 2025
Merged

Fix typo in JSON field name to resolve Patient MRP showing as undefined#665
yingbull merged 1 commit intodevelop/dogfishfrom
bugfix/typo-provider-field-mrp

Conversation

@D3V41
Copy link
Copy Markdown
Collaborator

@D3V41 D3V41 commented Oct 1, 2025

Issue

  • When linking documents, the Patient’s MRP was showing as "undefined".
  • This was caused by a typo in the JSON field name: the code used "providers" instead of "provider", which the JavaScript expected.

Fix

  • Corrected the typo by changing JSON key from "providers""provider".

Closes #650

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Oct 1, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Corrected a typo in the JSON field name to fix undefined Patient MRP by renaming the ‘providers’ key to ‘provider’ in the formatJSON method.

Class diagram for formatJSON method JSON output structure

classDiagram
class JSONOutput {
  label : String
  value : String
  providerNo : String
  provider : String
  nextAppt : String
  formattedName : String
}
Loading

File-Level Changes

Change Details Files
Typo fix in JSON output
  • Renamed JSON key from ‘providers’ to ‘provider’ in formatJSON
src/main/java/ca/openosp/openo/commn/web/SearchDemographicAutoComplete2Action.java

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 1, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 3e32daa.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yingbull yingbull self-requested a review October 1, 2025 15:50
@yingbull yingbull merged commit 11eef76 into develop/dogfish Oct 1, 2025
12 of 15 checks passed
@yingbull yingbull deleted the bugfix/typo-provider-field-mrp branch October 1, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Patient's MRP is "undefined" when linking documents

2 participants