Closed
Conversation
- fix /PMmodule/Admin/ProgramManagerForm.jsp by deleting DynaValidatorForm and taking attribute from request - fix /PMmodule/Admin/ProgramView/queue.jsp by correcting action's new name ProgramManager2Action - fix /billing/CA/ON/billingON3rdPayments.jsp by rewriting jstl - fix /casemgmt/CaseManagementEntry.jsp by rewriting jstl - fix /casemgmt/navigation.jsp by rewriting jstl - fix /casemgmt/showHistory.jsp by rewriting jstl - fix /oscarRx/CopyFavorites.jsp by moving the variable definition earlier. - fix /oscarRx/ListDrugs.jsp by moving the variable definition earlier. - fix /oscarRx/Preview.jsp by moving the variable definition earlier. - fix /oscarRx/Preview2.jsp by moving the variable definition earlier.
Reviewer's Guide by SourceryThis pull request modernizes several JSP files by replacing legacy Struts tags and scriptlets with JSTL and EL expressions. The changes primarily focus on improving code maintainability and following modern JSP best practices. Class diagram for JSP modernizationclassDiagram
class CaseManagementEntry {
-nested:form
-nested:iterate
-nested:checkbox
-nested:select
-nested:text
-nested:submit
-nested:write
+form
+c:forEach
+c:set
+c:if
+input
+select
+button
}
class ShowHistory {
-nested:write
-nested:iterate
-nested:notEmpty
-nested:equal
-nested:notEqual
+c:forEach
+c:out
+c:if
+fmt:formatDate
}
class Navigation {
-nested:iterate
+c:forEach
+c:set
+c:choose
+c:when
+c:otherwise
}
class BillingON3rdPayments {
+c:forEach
+c:if
+c:choose
+c:when
+c:otherwise
}
class ListDrugs {
+c:if
+c:redirect
}
class Preview2 {
+c:if
}
class ProgramManagerForm {
-DynaValidatorForm
+Program
}
class CopyFavorites {
+c:if
}
class CopyFavorites2 {
+c:set
}
class Preview {
+c:if
}
class Queue {
-ProgramManagerAction
+ProgramManager2Action
}
class ReceivePayment {
-ReceivePaymentActionForm
+ReceivePayment2Action
}
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @gongjian1981 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
yingbull
pushed a commit
that referenced
this pull request
Aug 8, 2025
…sult-link-in-patient-search Tweak - adding T (for tickler) and C (for consultation requests) into demographic search window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bug Fixes: