Skip to content

fix jsps compile errors#65

Closed
gongjian1981 wants to merge 4 commits intodevelop/bullfrogfrom
jsp-css-fix
Closed

fix jsps compile errors#65
gongjian1981 wants to merge 4 commits intodevelop/bullfrogfrom
jsp-css-fix

Conversation

@gongjian1981
Copy link
Copy Markdown

@gongjian1981 gongjian1981 commented Dec 14, 2024

Summary by Sourcery

Bug Fixes:

  • Fix JSP compilation errors by replacing deprecated 'nested' tags with standard JSTL tags and updating form actions to use context paths.

kateyang1998 and others added 2 commits December 13, 2024 16:00
 - fix /PMmodule/Admin/ProgramManagerForm.jsp by deleting DynaValidatorForm and taking attribute from request
 - fix /PMmodule/Admin/ProgramView/queue.jsp by correcting action's new name ProgramManager2Action
 - fix /billing/CA/ON/billingON3rdPayments.jsp by rewriting jstl
 - fix /casemgmt/CaseManagementEntry.jsp by rewriting jstl
 - fix /casemgmt/navigation.jsp by rewriting jstl
 - fix /casemgmt/showHistory.jsp by rewriting jstl
 - fix /oscarRx/CopyFavorites.jsp by moving the variable definition earlier.
 - fix /oscarRx/ListDrugs.jsp by moving the variable definition earlier.
 - fix /oscarRx/Preview.jsp by moving the variable definition earlier.
 - fix /oscarRx/Preview2.jsp by moving the variable definition earlier.
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Dec 14, 2024

Reviewer's Guide by Sourcery

This pull request modernizes several JSP files by replacing legacy Struts tags and scriptlets with JSTL and EL expressions. The changes primarily focus on improving code maintainability and following modern JSP best practices.

Class diagram for JSP modernization

classDiagram
    class CaseManagementEntry {
        -nested:form
        -nested:iterate
        -nested:checkbox
        -nested:select
        -nested:text
        -nested:submit
        -nested:write
        +form
        +c:forEach
        +c:set
        +c:if
        +input
        +select
        +button
    }
    class ShowHistory {
        -nested:write
        -nested:iterate
        -nested:notEmpty
        -nested:equal
        -nested:notEqual
        +c:forEach
        +c:out
        +c:if
        +fmt:formatDate
    }
    class Navigation {
        -nested:iterate
        +c:forEach
        +c:set
        +c:choose
        +c:when
        +c:otherwise
    }
    class BillingON3rdPayments {
        +c:forEach
        +c:if
        +c:choose
        +c:when
        +c:otherwise
    }
    class ListDrugs {
        +c:if
        +c:redirect
    }
    class Preview2 {
        +c:if
    }
    class ProgramManagerForm {
        -DynaValidatorForm
        +Program
    }
    class CopyFavorites {
        +c:if
    }
    class CopyFavorites2 {
        +c:set
    }
    class Preview {
        +c:if
    }
    class Queue {
        -ProgramManagerAction
        +ProgramManager2Action
    }
    class ReceivePayment {
        -ReceivePaymentActionForm
        +ReceivePayment2Action
    }
Loading

File-Level Changes

Change Details Files
Replace Struts nested tags with standard JSTL/EL expressions
  • Replace nested:form with standard HTML
  • Replace nested:iterate with <c:forEach>
  • Replace nested:write with ${} expressions
  • Replace nested:checkbox and nested:select with standard HTML form elements
  • Remove scriptlet code in favor of JSTL tags
src/main/webapp/casemgmt/CaseManagementEntry.jsp
src/main/webapp/casemgmt/showHistory.jsp
src/main/webapp/casemgmt/navigation.jsp
Improve JSP variable declarations and scope management
  • Move variable declarations to the top of JSP files
  • Properly scope variables using page context
  • Remove redundant type casting
  • Fix variable initialization patterns
src/main/webapp/oscarRx/ListDrugs.jsp
src/main/webapp/oscarRx/Preview2.jsp
src/main/webapp/PMmodule/Admin/ProgramManagerForm.jsp
src/main/webapp/oscarRx/CopyFavorites.jsp
src/main/webapp/oscarRx/CopyFavorites2.jsp
src/main/webapp/oscarRx/Preview.jsp
Update form handling and table rendering logic
  • Replace scriptlet-based table row generation with JSTL logic
  • Update form submission handling
  • Improve conditional rendering logic
  • Fix class import references
src/main/webapp/billing/CA/ON/billingON3rdPayments.jsp
src/main/webapp/PMmodule/Admin/ProgramView/queue.jsp
src/main/webapp/billing/CA/BC/receivePayment.jsp

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@yingbull yingbull self-requested a review December 14, 2024 00:32
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gongjian1981 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sebastian-j-ibanez sebastian-j-ibanez deleted the jsp-css-fix branch January 10, 2025 16:33
yingbull pushed a commit that referenced this pull request Aug 8, 2025
…sult-link-in-patient-search

Tweak - adding T (for tickler) and C (for consultation requests) into demographic search window
D3V41 pushed a commit that referenced this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants