Fixed some jsp compilation errors, Demographic Master Record page, and 500 error in Rx page.

[kateyang1998]

• Fixed some jsp files, now there are 33 files contain compilation errors.
• Fxied the 500 error in Rx page.
• Fixed the 500 error, and the css / js issues in Demographic Master Record page, the page is now the same as what we had before.

Summary by Sourcery

Fix JSP compilation errors, 500 errors on Rx and Demographic Master Record pages, and update JSP files for improved consistency.

Bug Fixes:

• Fix JSP compilation errors across multiple files, reducing the number of files with errors to 33.
• Resolve 500 error on the Rx page, ensuring the page loads correctly.
• Address 500 error and CSS/JS issues on the Demographic Master Record page, restoring its previous functionality.

Enhancements:

• Update JSP files to use 'UserPreference2Action' instead of 'UserPreferenceAction' for improved consistency and functionality.
• Modify taglib prefixes in JSP files for better clarity and standardization.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses several JSP compilation errors and fixes 500 errors in multiple pages. The main changes involve updating import statements, fixing tag library references, and correcting file paths. The changes primarily focus on maintaining consistent functionality while resolving compilation and runtime errors.

Class diagram for updated JSP actions

classDiagram
    class UserPreference2Action {
        +getTextData(Map prefs, String key)
        +getSelect(Map prefs, String key)
        +getEncounterFormHTML(Map prefs, String key)
        +getEformHTML(Map prefs, String key)
    }
    class Contact2Action {
        +fillContactNames(List<DemographicContact> dContacts)
        +searchAllContacts(String search_mode, String orderBy, String keyword)
        +searchContacts(String search_mode, String orderBy, String keyword)
        +getDemographicContacts(Demographic demographic)
        +searchProfessionalSpecialists(String keyword)
    }
    class EctViewRequest2Action {
        +fillFormValues(LoggedInInfo info, EctConsultationFormRequestForm form, Integer requestId)
        +fillFormValues(EctConsultationFormRequestForm form, String segmentId)
        +fillFormValues(EctConsultationFormRequestForm form, ConsultUtil consultUtil)
    }

Loading

File-Level Changes

Change	Details	Files
Updated JSP tag library references and import statements	Changed 'c' prefix to 'core' for JSTL core tag library Added missing JSTL tag library imports (core, functions, fmt) Fixed incorrect tag library URI references Updated tag attributes from 'name' to 'value' in c:out tags	oscarRx/TopLinks.jsp oscarEncounter/decisionSupport/guidelineDetail.jsp PMmodule/navigation_client.jsp demographic/displayHealthCareTeam.jsp oscarRx/AddReaction.jsp oscarRx/SelectPharmacy.jsp oscarRx/WriteScript.jsp
Updated Action class references to their new versions	Changed UserPreferenceAction to UserPreference2Action Updated ContactAction to Contact2Action Changed EctViewRequestAction to EctViewRequest2Action	provider/UserPreferences.jsp demographic/contactSearch.jsp demographic/procontactSearch.jsp oscarEncounter/oscarConsultationRequest/ConsultationFormRequest.jsp
Fixed resource file paths to use request context path	Updated paths to use request.getContextPath() for JavaScript files Updated paths to use request.getContextPath() for CSS files Fixed calendar stylesheet and JavaScript file paths	demographic/demographiceditdemographic.jsp
Fixed JSP variable declarations and scope issues	Added missing variable declarations Fixed incorrect variable scoping Corrected attribute access from request/session scope	oscarRx/SearchDrug3.jsp PMmodule/ClientManager/view_admission.jsp PMmodule/ClientManager/showHistory.jsp

Possibly linked issues

• removeMember() Method Always Returns True, Masking Potential Failures #52: The PR fixes the 500 error on the Demographic Master Record page, matching the issue's focus.
• Added DownloadInIterceptor import to the classes #1: The PR fixes the 500 error on the Rx page, directly related to the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @kateyang1998 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please clarify whether there are still 33 JSP files with compilation errors remaining, or if that was the initial count that has now been fixed. The current wording is ambiguous.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[kateyang1998]

Hey @kateyang1998 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please clarify whether there are still 33 JSP files with compilation errors remaining, or if that was the initial count that has now been fixed. The current wording is ambiguous.

Here's what I looked at during the review
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

There are still 33 JSP files with compilation errors remaining, was 52 initially.