StringBuilder fixes

[sebastian-j-ibanez]

Changes made

This PR has a few last minute fixes we've been meaning to make in bullfrog. These include:

• Import apache.commons.lang3 instead of apache.commons.lang for StringBuilder and ReflectionToStringBuilder in several classes.
  • The lang3 version fixes several failing unit tests.
• Targeting Java 21 in the maven compiler plugin
• Fixing a double semi-colon type in EctConEditSpecialists2Action.java

Summary by Sourcery

Fix import statements to use 'apache.commons.lang3' for StringBuilder and ReflectionToStringBuilder, update Maven compiler plugin to target Java 21, and correct a typo in 'EctConEditSpecialists2Action.java'.

Bug Fixes:

• Correct import statements to use 'apache.commons.lang3' instead of 'apache.commons.lang' for StringBuilder and ReflectionToStringBuilder, resolving several failing unit tests.
• Fix a typo involving a double semi-colon in 'EctConEditSpecialists2Action.java'.

Build:

• Update the Maven compiler plugin to target Java 21.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR implements three main changes: upgrading from Apache Commons Lang to Lang3 for StringBuilder and ReflectionToStringBuilder usage, updating the Java version from 11 to 21 in the Maven compiler configuration, and fixing a typographical error in a Java class.

Class diagram for updated imports in AbstractModel and PreventionSearchTo1

classDiagram
    class AbstractModel {
        +ReflectionToStringBuilder toStringBuilder
    }
    class PreventionSearchTo1 {
        +ReflectionToStringBuilder toStringBuilder
    }
    note for AbstractModel "Updated import to org.apache.commons.lang3.builder.ReflectionToStringBuilder"
    note for PreventionSearchTo1 "Updated import to org.apache.commons.lang3.builder.ReflectionToStringBuilder"

Loading

File-Level Changes

Change	Details	Files
Upgrade Apache Commons Lang dependency from legacy version to Lang3	Replace import of org.apache.commons.lang.builder.ReflectionToStringBuilder with org.apache.commons.lang3.builder.ReflectionToStringBuilder Update imports to fix failing unit tests	src/main/java/org/oscarehr/common/model/AbstractModel.java src/main/java/org/oscarehr/ws/rest/to/model/PreventionSearchTo1.java
Update Java version in Maven compiler configuration	Change source and target Java version from 11 to 21	pom.xml

Possibly linked issues

• Added DownloadInIterceptor import to the classes #1: PR fixes StringBuilder imports which resolves some failing unit tests mentioned in the issue.
• Added DownloadInIterceptor import to the classes #1: The PR addresses unit test failures by updating StringBuilder imports, directly related to the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @sebastian-j-ibanez - I've reviewed your changes - here's some feedback:

Overall Comments:

• The jump from Java 11 to 21 is significant. Please confirm that comprehensive testing has been performed with Java 21 and detail any compatibility issues that were discovered and addressed.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}