Skip to content

Added develop/dogfish into the maven build#496

Merged
yingbull merged 4 commits intodevelop/dogfishfrom
update-maven-project-to-include-dogfish
Sep 2, 2025
Merged

Added develop/dogfish into the maven build#496
yingbull merged 4 commits intodevelop/dogfishfrom
update-maven-project-to-include-dogfish

Conversation

@LiamStanziani
Copy link
Copy Markdown
Collaborator

@LiamStanziani LiamStanziani commented Sep 2, 2025

Summary by Sourcery

Update the GitHub Actions Maven project workflow to add support for the develop/dogfish branch and standardize the Docker container name used in CI steps.

CI:

  • Include develop/dogfish branch in Maven CI workflow triggers
  • Rename Docker container in exec commands to openo-tomcat-dev across build and lint jobs

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Sep 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request updates the Maven GitHub Actions workflow by adding the new develop/dogfish branch to the list of triggers and by renaming the Docker exec container alias to openo-tomcat-dev across all build steps.

File-Level Changes

Change Details Files
Extended Maven workflow triggers to include develop/dogfish
  • Added develop/dogfish to the push triggers list
  • Added develop/dogfish to the pull_request triggers list
.github/workflows/maven-project.yml
Standardized Docker container name in workflow commands
  • Replaced docker exec alias devcontainer-open-o-1 with openo-tomcat-dev for make lock
  • Replaced docker exec alias devcontainer-open-o-1 with openo-tomcat-dev for make install
  • Replaced docker exec alias devcontainer-open-o-1 with openo-tomcat-dev for mvn package -Pjspc
  • Replaced docker exec alias devcontainer-open-o-1 with openo-tomcat-dev for mvn checkstyle:checkstyle
.github/workflows/maven-project.yml

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@LiamStanziani LiamStanziani marked this pull request as ready for review September 2, 2025 18:37
@yingbull yingbull merged commit ff69937 into develop/dogfish Sep 2, 2025
11 checks passed
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Ensure the updated container name 'openo-tomcat-dev' matches your devcontainer configuration and update it uniformly across all workflow files if needed.
  • Consider extracting the container name into a single workflow-level variable to avoid repeating the literal in multiple steps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Ensure the updated container name 'openo-tomcat-dev' matches your devcontainer configuration and update it uniformly across all workflow files if needed.
- Consider extracting the container name into a single workflow-level variable to avoid repeating the literal in multiple steps.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yingbull yingbull deleted the update-maven-project-to-include-dogfish branch January 8, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update maven-project to allow building on PRs that are targeting develop/dogfish

2 participants