Skip to content

Fixed some bugs in develop/dogfish#490

Merged
yingbull merged 3 commits intodevelop/dogfishfrom
issue-477-dogfish-bug-fix
Aug 29, 2025
Merged

Fixed some bugs in develop/dogfish#490
yingbull merged 3 commits intodevelop/dogfishfrom
issue-477-dogfish-bug-fix

Conversation

@kateyang1998
Copy link
Copy Markdown

@kateyang1998 kateyang1998 commented Aug 29, 2025

  • Fixed 404 error, css style in EChart -> Disease Registry window, and the functionality of Resolve tab
  • Fixed tickler note saving issue

Summary by Sourcery

Fix 404 errors in Disease Registry, correct CSS loading path in dxResearch views, and handle invalid program numbers when saving tickler notes

Bug Fixes:

  • Add Struts action mappings for oscarResearch/dxresearch URLs to prevent 404 errors
  • Update dxResearch JSPs to reference CSS via the servlet context path
  • Catch NumberFormatException for invalid program numbers to fix tickler note saving

@kateyang1998 kateyang1998 requested a review from yingbull August 29, 2025 20:03
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Aug 29, 2025

Reviewer's Guide

Refactors note role determination to handle invalid program numbers, adds missing Struts action mappings to resolve 404 errors for dxresearch endpoints, and updates JSPs to reference dxResearch.css with the proper context path.

Class diagram for CaseManagementNote and ProgramProvider interaction update

classDiagram
    class CaseManagementNote {
        +String getProgram_no()
        +void setReporter_caisi_role(String roleId)
        +String getProviderNo()
    }
    class CaseManagementEntry2Action {
        +static boolean determineNoteRole(CaseManagementNote note, String provider)
    }
    class ProgramProviderDao {
        +ProgramProvider getProgramProvider(String providerNo, Long programId)
    }
    class ProgramProvider {
        +Long getRoleId()
    }
    CaseManagementEntry2Action --> CaseManagementNote
    CaseManagementEntry2Action --> ProgramProviderDao
    ProgramProviderDao --> ProgramProvider
Loading

File-Level Changes

Change Details Files
Improve program provider lookup in note role determination
  • Wrap program number parsing in try-catch to avoid NumberFormatException
  • Validate programId > 0 before DAO lookup
  • Skip lookup when program number is invalid
src/main/java/ca/openosp/openo/casemgmt/web/CaseManagementEntry2Action.java
Add missing Struts action mappings for dxresearch paths
  • Insert new action mapping for setupDxResearch under dxresearch path
  • Insert new action mapping for dxResearchUpdate under dxresearch path
src/main/webapp/WEB-INF/classes/struts.xml
Standardize CSS includes to use contextPath for dxResearch.css
  • Replace relative href with contextPath-based URL for CSS in JSP headers
  • Update all affected dxResearch JSPs to reference the correct path
src/main/webapp/oscarResearch/oscarDxResearch/dxResearchSelectAssociations.jsp
src/main/webapp/oscarResearch/oscarDxResearch/dxResearch.jsp
src/main/webapp/oscarResearch/oscarDxResearch/dxResearchCustomization.jsp
src/main/webapp/oscarResearch/oscarDxResearch/dxResearchEditQuickList.jsp
src/main/webapp/oscarResearch/oscarDxResearch/dxResearchNewQuickList.jsp
src/main/webapp/oscarResearch/oscarDxResearch/dxResearchSelectQuickList.jsp

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yingbull yingbull merged commit 8c525bd into develop/dogfish Aug 29, 2025
9 checks passed
@yingbull yingbull deleted the issue-477-dogfish-bug-fix branch January 8, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants