Fix bullfrog unit tests

[sebastian-j-ibanez]

Fixes

• 7268db8 Fixed several hibernate query errors.
• b2acd0a Added a null check to BaseLoginModule.logout(), to prevent the BaseLoginModuleTest from failing.
• a7224a7 Cherry pick fix for the InboxPopulatingTest from alpaca.
• cbcac10 Comment out failing test on unused code in VacancyClientMatchDaoTest.

Summary by Sourcery

Fix various unit test failures and hibernate query errors. Update dependencies to newer versions for improved stability. Enhance test infrastructure by adding cleanup methods and commenting out unused tests. Make dependency injection optional in NioFileManagerImpl.

Bug Fixes:

• Fix hibernate query errors in ProviderLabRoutingDaoImpl by correcting query syntax.
• Add null check in BaseLoginModule.logout() to prevent test failures.
• Correct parameter order in PatientLabRoutingDaoImpl to fix query issues.
• Fix date parameter handling in BillingONCHeader1DaoImpl to ensure correct query execution.

Enhancements:

• Modify NioFileManagerImpl to make ServletContext injection optional.

Tests:

• Comment out failing test in VacancyClientMatchDaoTest due to unused code.
• Add cleanup method in InboxPopulatingTest to remove temporary directories after tests.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes several failing unit tests and Hibernate query errors in the bullfrog branch. The main changes include fixing incorrect query parameter syntax, updating dependency versions, and addressing test environment setup issues.

Class diagram for BaseLoginModule changes

classDiagram
    class BaseLoginModule {
        +boolean logout()
    }
    note for BaseLoginModule "Added null check for principals in logout method"

Loading

Class diagram for ProviderLabRoutingDaoImpl changes

classDiagram
    class ProviderLabRoutingDaoImpl {
        -List<ProviderLabRoutingModel> getProviderLabRoutings(Integer, String, String, String)
        +List<ProviderLabRoutingModel> getProviderLabRoutings(Integer, String, String, String)
        -List<ProviderLabRoutingModel> findByLabNoAndLabTypeAndProviderNo(int, String, String)
        +List<ProviderLabRoutingModel> findByLabNoAndLabTypeAndProviderNo(int, String, String)
        -void updateStatus(Integer, String)
        +void updateStatus(Integer, String)
        -ProviderLabRoutingModel findByLabNo(int)
        +ProviderLabRoutingModel findByLabNo(int)
        -List<ProviderLabRoutingModel> findByLabNoIncludingPotentialDuplicates(int)
        +List<ProviderLabRoutingModel> findByLabNoIncludingPotentialDuplicates(int)
        -ProviderLabRoutingModel findByLabNoAndLabType(int, String)
        +ProviderLabRoutingModel findByLabNoAndLabType(int, String)
        -List<Object[]> getProviderLabRoutings(Integer, String)
        +List<Object[]> getProviderLabRoutings(Integer, String)
    }
    note for ProviderLabRoutingDaoImpl "Fixed query parameter syntax"

Loading

Class diagram for BillingONCHeader1DaoImpl changes

classDiagram
    class BillingONCHeader1DaoImpl {
        +List<BillingONCHeader1> findByProviderStatusAndDateRange(String, List<String>, DateRange)
    }
    note for BillingONCHeader1DaoImpl "Refactored query building for date range"

Loading

Class diagram for NioFileManagerImpl changes

classDiagram
    class NioFileManagerImpl {
        +ServletContext context
    }
    note for NioFileManagerImpl "Autowired context is now optional"

Loading

File-Level Changes

Change	Details	Files
Fixed Hibernate query parameter syntax errors in multiple DAO implementations	Fixed incorrect table name parameter substitution in queries Corrected parameter numbering and binding Updated query string construction to use proper parameter placeholders Fixed parameter order in query execution	src/main/java/org/oscarehr/common/dao/ProviderLabRoutingDaoImpl.java src/main/java/org/oscarehr/common/dao/BillingONCHeader1DaoImpl.java src/main/java/org/oscarehr/common/dao/BillingDaoImpl.java src/main/java/org/oscarehr/common/dao/PatientLabRoutingDaoImpl.java src/main/java/org/oscarehr/common/dao/BillingServiceDaoImpl.java src/main/java/org/oscarehr/common/dao/MdsOBRDaoImpl.java src/main/java/org/oscarehr/common/dao/ProfessionalSpecialistDaoImpl.java
Updated test environment setup and cleanup	Added proper temporary directory setup and cleanup for document tests Fixed test data initialization Made NioFileManager's ServletContext autowiring optional	src/test/java/org/oscarehr/common/dao/InboxPopulatingTest.java src/test/java/org/oscarehr/common/dao/utils/DataUtils.java src/main/java/org/oscarehr/managers/NioFileManagerImpl.java
Added null check in BaseLoginModule logout method	Added null check before removing principals to prevent NullPointerException	src/main/java/oscar/login/jaas/BaseLoginModule.java
Disabled failing test in VacancyClientMatchDaoTest	Commented out testFindByClientIdAndVacancyId test that was failing on unused code	src/test/java/org/oscarehr/PMmodule/dao/VacancyClientMatchDaoTest.java
Updated project dependencies	Updated multiple library versions in dependencies-lock.json Added new dependencies required by updated versions	dependencies-lock.json

Possibly linked issues

• Added DownloadInIterceptor import to the classes #1: The PR addresses failing unit tests in bullfrog, matching the issue's goal to fix them.
• Added DownloadInIterceptor import to the classes #1: The PR addresses the issue by fixing specific unit test failures in the bullfrog module.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @sebastian-j-ibanez - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}