Skip to content

Java11 upg#25

Merged
yingbull merged 5 commits intodevelop/bullfrogfrom
java11-upg
Nov 19, 2024
Merged

Java11 upg#25
yingbull merged 5 commits intodevelop/bullfrogfrom
java11-upg

Conversation

@garciaerin
Copy link
Copy Markdown

@garciaerin garciaerin commented Nov 19, 2024

New PR for Java 11. Same commits.

Summary by Sourcery

Upgrade the project to Java 11 by updating dependencies and Maven compiler settings, and modify the Dockerfile to use a Java 11 base image.

Enhancements:

  • Upgrade project dependencies to support Java 11, including jaxws-ri, jaxb-api, javax.annotation-api, and jaxb-impl.
  • Update Maven compiler plugin configuration to use Java 11 as the source and target version.

Build:

  • Modify Dockerfile to use openjdk:11-jdk-slim as the base image and configure Tomcat environment variables.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Nov 19, 2024

Reviewer's Guide by Sourcery

This PR upgrades the project from Java 8 to Java 11, which involves updating the Maven compiler settings, Docker base image, and adding necessary dependencies that were removed from the JDK since Java 9.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update Maven configuration for Java 11
  • Changed compiler source and target from 1.8 to 11
pom.xml
Add Java 11 required dependencies
  • Added JAXWS-RI dependency version 2.3.3
  • Added JAXB API dependency version 2.3.1
  • Added javax.annotation API dependency version 1.3.2
  • Added JAXB implementation dependency version 2.3.3 for Tomcat 9.0.97
pom.xml
Update Docker configuration for Java 11
  • Changed base image from tomcat:9.0.56-jdk8-openjdk to openjdk:11-jdk-slim
  • Added Tomcat installation from official Tomcat 9.0.97 image
  • Updated system library dependencies for Java 11 compatibility
  • Added environment variables for Tomcat configuration
.devcontainer/development/Dockerfile

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@socket-security
Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
maven/com.sun.xml.bind/jaxb-impl@2.3.3 eval, filesystem, network 0 2.37 MB
maven/com.sun.xml.ws/jaxws-ri@2.3.3 Transitive: eval, filesystem, network, unsafe +7 7.77 MB

View full report↗︎

@yingbull yingbull self-requested a review November 19, 2024 19:06
@yingbull yingbull merged commit f8ed437 into develop/bullfrog Nov 19, 2024
@sebastian-j-ibanez sebastian-j-ibanez deleted the java11-upg branch January 10, 2025 16:33
Jdarji2130 pushed a commit to Jdarji2130/Open-O-jay that referenced this pull request Mar 23, 2025
Jdarji2130 pushed a commit to Jdarji2130/Open-O-jay that referenced this pull request Mar 23, 2025
yingbull pushed a commit that referenced this pull request May 9, 2025
Fix: echart not closing properly after signing/saving rx note
D3V41 pushed a commit that referenced this pull request Sep 4, 2025
D3V41 pushed a commit that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants