Skip to content

Clean up js files#24

Merged
yingbull merged 2 commits intodevelop/bullfrogfrom
clean-up-js-files
Nov 19, 2024
Merged

Clean up js files#24
yingbull merged 2 commits intodevelop/bullfrogfrom
clean-up-js-files

Conversation

@kateyang1998
Copy link
Copy Markdown

@kateyang1998 kateyang1998 commented Nov 19, 2024

  • Removed the custom unreferenced .js files
  • Removed the unused code in some referenced .js files

Summary by Sourcery

Clean up JavaScript files by removing unreferenced files and deleting unused code from existing files to enhance code maintainability and reduce clutter.

Enhancements:

  • Remove unused code from referenced JavaScript files to improve maintainability and reduce clutter.

Chores:

  • Delete unreferenced JavaScript files from the project to clean up the codebase.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Nov 19, 2024

Reviewer's Guide by Sourcery

This pull request focuses on cleaning up JavaScript files by removing unused code and unreferenced files. The changes include removing commented-out code blocks, empty functions, trailing whitespace, and entire JavaScript files that are no longer referenced in the application.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed commented-out code blocks and unused functions from active JavaScript files
  • Removed unused function implementations
  • Deleted commented-out code blocks that were previously disabled
  • Removed redundant comments
  • Cleaned up trailing whitespace and empty lines at end of files
src/main/webapp/share/javascript/oscarMDSIndex.js
src/main/webapp/js/HSFO2.js
src/main/webapp/share/javascript/sorter.js
src/main/webapp/web/record/rx/rxModel.js
src/main/webapp/web/record/summary/summaryController.js
src/main/webapp/web/record/rx/print/print.component.js
src/main/webapp/js/bootstrap-datepicker.js
Deleted unreferenced JavaScript files that are no longer used in the application
  • Removed unused custom JavaScript files
  • Removed deprecated handler files
  • Removed unused form-related JavaScript files
  • Removed legacy calendar and menu JavaScript files
src/main/webapp/hcHandler/hcHandlerSearch.js
src/main/webapp/js/DemographicInfo.js
src/main/webapp/js/custom/default/adddemo.js
src/main/webapp/js/custom/default/master.js
src/main/webapp/js/custom/eyeform/master.js
src/main/webapp/js/hideexpand.js
src/main/webapp/js/oscarRx.js
src/main/webapp/share/calendar/calendar-handler_stripped.js
src/main/webapp/share/javascript/forms/forms-quill-image-placeholder.js
src/main/webapp/share/javascript/forms/forms-quill-register-inline-styles.js

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kateyang1998 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yingbull yingbull merged commit a5e11bd into develop/bullfrog Nov 19, 2024
@sebastian-j-ibanez sebastian-j-ibanez deleted the clean-up-js-files branch January 10, 2025 16:33
Jdarji2130 pushed a commit to Jdarji2130/Open-O-jay that referenced this pull request Mar 23, 2025
yingbull pushed a commit that referenced this pull request May 9, 2025
Update MessageUploader.java ExcellerisON provider matching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants