Skip to content

chore: remove jpedal dependency and local repository files#2205

Merged
yingbull merged 1 commit intodevelopfrom
claude/issue-2203-20260128-0230
Jan 28, 2026
Merged

chore: remove jpedal dependency and local repository files#2205
yingbull merged 1 commit intodevelopfrom
claude/issue-2203-20260128-0230

Conversation

@github-actions
Copy link
Copy Markdown

@github-actions github-actions bot commented Jan 28, 2026

Summary

Remove jpedal dependency from pom.xml and all related files from local_repo/ now that all jpedal usage has been migrated to Apache PDFBox.

Changes

  • Removed jpedal dependency from pom.xml (lines 529-534)
  • Removed 6 jpedal files from local_repo/org/jpedal/lgpl/
    • jpedal-lgpl.jar
    • jpedal-lgpl.pom
    • jpedal-lgpl.jar.md5 / .sha1
    • jpedal-lgpl.pom.md5 / .sha1

Testing

CI will verify:

  • Project builds successfully
  • All tests pass
  • No jpedal imports remain in codebase

Related Issues

Fixes #2203
Parent epic: #2170 (jpedal → PDFBox migration)


🤖 Generated with Claude Code


Summary by cubic

Remove the legacy jpedal dependency and its local repo artifacts now that PDF rendering uses Apache PDFBox. This cleans up local_repo and simplifies the Maven build, completing issue #2203 in the jpedal → PDFBox migration (#2170).

  • Dependencies
    • Removed org:jpedal from pom.xml
    • Deleted six jpedal files from local_repo/org/jpedal/lgpl/

Written for commit 9856c9d. Summary will update on new commits.

Remove jpedal dependency from pom.xml and all related files from local_repo/
now that all jpedal usage has been migrated to Apache PDFBox.

- Removed jpedal dependency from pom.xml (lines 529-534)
- Removed 6 jpedal files from local_repo/org/jpedal/lgpl/

Fixes #2203

Co-authored-by: Michael Yingbull <yingbull@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 28, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@yingbull
Copy link
Copy Markdown

@claude review

@github-actions
Copy link
Copy Markdown
Author

github-actions bot commented Jan 28, 2026

Claude finished @yingbull's task in 1m 28s —— View job


Code Review - Dependency Lock Files Need Update ⚠️

Summary

This PR successfully removes the jpedal dependency from pom.xml and deletes all related JAR files from local_repo/. The changes are clean and complete for those files. However, the Maven dependency lock files need to be regenerated to reflect the removal.

Review Findings

✅ What's Working
  1. pom.xml Changes - Clean removal of jpedal dependency

    • Removed lines 529-534 containing the jpedal dependency declaration
    • No other pom.xml changes needed
  2. Local Repository Cleanup - All jpedal files properly deleted

    • local_repo/org/jpedal/lgpl/jpedal-lgpl.jar (deleted)
    • local_repo/org/jpedal/lgpl/jpedal-lgpl.pom (deleted)
    • ✅ All checksum files (.md5, .sha1) deleted
    • ✅ Entire local_repo/org/jpedal/ directory removed
  3. No Import References - Zero jpedal imports remain in Java files

  4. Comment References - Only migration documentation comments remain

    • NioFileManagerImpl.java:245-246 - Comments documenting migration from jpedal to PDFBox
    • ManageDocument2Action.java:1481-1482 - Similar migration documentation comments
    • These are intentional and helpful for historical context
⚠️ Issue: Dependency Lock Files Not Updated

The following files still contain jpedal entries and need to be regenerated:

  1. dependencies-lock.json (line 3427-3434):

    {
      "groupId" : "org",
      "artifactId" : "jpedal",
      "version" : "lgpl",
      "scope" : "compile",
      "type" : "jar",
      "optional" : false,
      "integrity" : "sha512:nYKlrF2wKm0zGaoP6W0snVqzxznHnNj9EbQDlJk9h0ijYcmQ5x+hYLt41EAx9vFRtV3llxNGjjZD5LxKV0GdUg=="
    }
  2. dependencies-lock-modern.json (line 3491-3495):

    {
      "groupId" : "org",
      "artifactId" : "jpedal",
      "version" : "lgpl",
      "scope" : "compile",
      ...
    }
🔧 Required Action

Before merging this PR, you need to regenerate the dependency lock files:

make lock

This command will:

  • Resolve the current Maven dependency tree (without jpedal)
  • Regenerate dependencies-lock.json and dependencies-lock-modern.json
  • Remove the jpedal entries from both files

Per the CLAUDE.md DevContainer Custom Scripts section, the make lock command updates Maven dependency lock files.

Verification Checklist

  • jpedal dependency removed from pom.xml
  • jpedal JAR files removed from local_repo/
  • No jpedal imports in Java source files ✅
  • Dependency lock files regenerated ⚠️ ACTION REQUIRED
  • CI build passes (pending lock file update)
  • Tests pass (pending lock file update)

Recommendation

Request Changes: Please run make lock to regenerate the dependency lock files, then commit and push the updated files. Once that's done, this PR will be ready to merge.

The core cleanup work is excellent - this is just a procedural step to keep the lock files in sync with pom.xml.

Migration Context

This PR completes the jpedal → PDFBox migration epic (#2170):

Once the lock files are updated, the migration will be complete!


Tasks

  • Read pom.xml to verify dependency removal
  • Search codebase for remaining jpedal references
  • Verify PDFBox migration completeness
  • Provide comprehensive review feedback

--- | Branch: claude/issue-2203-20260128-0230

@yingbull yingbull self-requested a review January 28, 2026 02:57
@yingbull yingbull merged commit df7ca59 into develop Jan 28, 2026
15 checks passed
@yingbull yingbull deleted the claude/issue-2203-20260128-0230 branch January 28, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove jpedal dependency from pom.xml and local_repo

2 participants