Skip to content

fix: migrate NioFileManagerImpl from jpedal to Apache PDFBox #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yingbull merged 3 commits into from
Jan 28, 2026
Merged

fix: migrate NioFileManagerImpl from jpedal to Apache PDFBox #2200

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36e95cd
fix: migrate NioFileManagerImpl from jpedal to Apache PDFBox
github-actions[bot] Jan 28, 2026
dde9d26
fix: add comprehensive error handling to PDF page rendering
github-actions[bot] Jan 28, 2026
11a9974
Merge branch 'develop' into claude/issue-2183-20260128-0117
yingbull Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 27 additions & 18 deletions src/main/java/ca/openosp/openo/managers/NioFileManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
Expand All @@ -43,9 +42,10 @@
import ca.openosp.OscarProperties;
import org.apache.commons.io.FilenameUtils;
import org.apache.logging.log4j.Logger;
import org.jpedal.PdfDecoder;
import org.jpedal.exception.PdfException;
import org.jpedal.fonts.FontMappings;
import org.apache.pdfbox.pdmodel.PDDocument;
import org.apache.pdfbox.rendering.PDFRenderer;
import org.apache.pdfbox.rendering.ImageType;
import javax.imageio.ImageIO;
import ca.openosp.openo.utility.LoggedInInfo;
import ca.openosp.openo.utility.MiscUtils;
import ca.openosp.openo.utility.PathValidationUtils;
Expand Down Expand Up @@ -231,22 +231,31 @@ public Path createCacheVersion2(LoggedInInfo loggedInInfo, String sourceDirector
return null;
}

PdfDecoder decode_pdf = new PdfDecoder(true);
FontMappings.setFontReplacements();
decode_pdf.useHiResScreenDisplay(true);
decode_pdf.setExtractionMode(0, 96, 96 / 72f);
try (PDDocument document = PDDocument.load(sourceFile.toFile())) {
int pageIndex = pageNum - 1;
int pageCount = document.getNumberOfPages();

try (InputStream inputStream = Files.newInputStream(sourceFile)) {
decode_pdf.openPdfFileFromInputStream(inputStream, false);
BufferedImage image_to_save = decode_pdf.getPageAsImage(pageNum);
decode_pdf.getObjectStore().saveStoredImage(cacheFilePath.toString(), image_to_save, true, false, "png");
// Validate page index is within bounds
if (pageIndex < 0 || pageIndex >= pageCount) {
log.error("Requested page " + pageNum + " is out of range for document with " + pageCount + " pages");
return null;
}

PDFRenderer renderer = new PDFRenderer(document);
// Render at 96 DPI to match jpedal settings
// Note: jpedal uses 1-based page indexing, PDFBox uses 0-based
BufferedImage image_to_save = renderer.renderImageWithDPI(pageIndex, 96, ImageType.RGB);

// Check ImageIO.write success (returns false on failure)
if (!ImageIO.write(image_to_save, "png", cacheFilePath.toFile())) {
log.error("Failed to write PNG image to cache file: " + cacheFilePath);
return null;
}

image_to_save.flush();
} catch (IOException e) {
log.error("Error", e);
} catch (PdfException e) {
log.error("Error", e);
} finally {
decode_pdf.flushObjectValues(true);
decode_pdf.closePdfFile();
log.error("Error rendering PDF page to cache", e);
Comment thread
yingbull marked this conversation as resolved.
return null; // Must return null on error
}
}

Expand Down
Loading