Merged
Conversation
Reviewer's Guide by SourceryThis PR upgrades the project from Java 8 to Java 11. The implementation involves updating the Maven compiler configuration and adding necessary Java 11 dependencies in pom.xml, along with updating the base Docker image to use JDK 11. Class diagram for updated dependencies in pom.xmlclassDiagram
class ProjectDependencies {
+Dependency jaxws-ri
+Dependency jaxb-api
+Dependency javax.annotation-api
}
class Dependency {
+String groupId
+String artifactId
+String version
}
ProjectDependencies --> Dependency
note for ProjectDependencies "Updated dependencies for Java 11 support"
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.
- updated packages - updated dependency versions - added dependency
- uses OpenJDK version of java 11 instead of Temurin.
yingbull
approved these changes
Nov 13, 2024
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Upgrade the project to use Java 11 by updating the Maven compiler plugin version and dependencies in pom.xml, and changing the Dockerfile to use a JDK 11 base image.
Build:
Deployment: