Skip to content

Updated log4j versions to 2.25.3 to fix a security vulnerability#1056

Merged
yingbull merged 1 commit intodevelop/dogfishfrom
1055-apache-log4j-dependency-update
Dec 29, 2025
Merged

Updated log4j versions to 2.25.3 to fix a security vulnerability#1056
yingbull merged 1 commit intodevelop/dogfishfrom
1055-apache-log4j-dependency-update

Conversation

@LiamStanziani
Copy link
Copy Markdown
Collaborator

@LiamStanziani LiamStanziani commented Dec 22, 2025

In this PR, I have:

  • Updated log4j versions to 2.25.3 to fix a security vulnerability

I have tested this by:

  • Smoke testing the application, comparing to logs from the develop/dogfish branch

Summary by Sourcery

Update Log4j dependencies to the latest patched 2.25.3 release to address security concerns.

Bug Fixes:

  • Address known security vulnerabilities by upgrading Log4j from 2.25.1 to 2.25.3 in the build configuration.

Build:

  • Bump the shared Log4j version property in pom.xml and refresh dependency lock files to use Log4j 2.25.3.

Summary by Sourcery

Upgrade Log4j dependencies to a patched 2.25.3 release to address security concerns and refresh dependency locks accordingly.

Bug Fixes:

  • Mitigate known Log4j security vulnerabilities by upgrading from version 2.25.1 to 2.25.3.

Build:

  • Update the shared Log4j version property in pom.xml and regenerate dependency lock files to use Log4j 2.25.3.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Dec 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the shared Log4j version used by the project to 2.25.3 and refreshes dependency lock files so all modules/builds consume the patched logging libraries for the security fix.

File-Level Changes

Change Details Files
Upgrade the shared Log4j dependency version and align locked dependency metadata to 2.25.3.
  • Bump the central Log4j version property from 2.25.1 to 2.25.3 in the Maven build configuration so all modules inherit the patched version.
  • Regenerate or update modern dependency lock metadata to reflect the new Log4j coordinates and transitive versions.
  • Regenerate or update legacy dependency lock metadata to keep it consistent with the updated Log4j version and its transitive dependency graph.
pom.xml
dependencies-lock-modern.json
dependencies-lock.json

Assessment against linked issues

Issue Objective Addressed Explanation
#1055 Update the Apache Log4j dependency from version 2.25.1 to at least 2.25.3 (specifically 2.25.3) in the project configuration to address the security vulnerability.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
maven/org.apache.logging.log4j:log4j-1.2-api 2.25.3 🟢 8.3
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
CI-Tests🟢 44 out of 9 merged PRs checked by a CI test -- score normalized to 4
CII-Best-Practices⚠️ 2badge detected: in_progress
Code-Review⚠️ 1found 20 unreviewed changesets out of 23 -- score normalized to 1
Contributors🟢 1046 different organizations found -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing🟢 10project is fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) out of 30 and 17 issue activity out of 30 found in the last 90 days -- score normalized to 10
Packaging⚠️ -1no published package detected
Pinned-Dependencies🟢 10all dependencies are pinned
SAST⚠️ 2SAST tool is not run on all commits -- score normalized to 2
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 10no vulnerabilities detected
maven/org.apache.logging.log4j:log4j-api 2.25.3 🟢 8.3
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
CI-Tests🟢 44 out of 9 merged PRs checked by a CI test -- score normalized to 4
CII-Best-Practices⚠️ 2badge detected: in_progress
Code-Review⚠️ 1found 20 unreviewed changesets out of 23 -- score normalized to 1
Contributors🟢 1046 different organizations found -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing🟢 10project is fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) out of 30 and 17 issue activity out of 30 found in the last 90 days -- score normalized to 10
Packaging⚠️ -1no published package detected
Pinned-Dependencies🟢 10all dependencies are pinned
SAST⚠️ 2SAST tool is not run on all commits -- score normalized to 2
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 10no vulnerabilities detected
maven/org.apache.logging.log4j:log4j-core 2.25.3 🟢 8.3
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
CI-Tests🟢 44 out of 9 merged PRs checked by a CI test -- score normalized to 4
CII-Best-Practices⚠️ 2badge detected: in_progress
Code-Review⚠️ 1found 20 unreviewed changesets out of 23 -- score normalized to 1
Contributors🟢 1046 different organizations found -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing🟢 10project is fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) out of 30 and 17 issue activity out of 30 found in the last 90 days -- score normalized to 10
Packaging⚠️ -1no published package detected
Pinned-Dependencies🟢 10all dependencies are pinned
SAST⚠️ 2SAST tool is not run on all commits -- score normalized to 2
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities🟢 10no vulnerabilities detected

Scanned Files

  • pom.xml

@LiamStanziani LiamStanziani marked this pull request as ready for review December 22, 2025 14:38
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yingbull yingbull merged commit 649ee09 into develop/dogfish Dec 29, 2025
13 of 14 checks passed
@yingbull yingbull deleted the 1055-apache-log4j-dependency-update branch December 29, 2025 22:39
@LiamStanziani LiamStanziani mentioned this pull request Jan 8, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dependency]: Update Apache Log4j to version >= 2.25.3 to fix a security vulnerability

2 participants