Skip to content

Conversation

@james-elicx
Copy link
Collaborator

@james-elicx james-elicx commented Dec 6, 2025

Intended to let people get the full logs from Wrangler instead of only stderr when an error happens

related to #1030 (comment)

image

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2025

🦋 Changeset detected

Latest commit: 17e913e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1034

commit: 17e913e

@james-elicx james-elicx requested a review from vicb December 6, 2025 15:04
@vicb
Copy link
Contributor

vicb commented Dec 6, 2025

Thanks James for looking into that 🙏

I haven't looked at the details of your changes yet but you say "relates to 1030". Do you have any idea why the user does not get error logs there?

One more thought: having more info with OPEN_NEXT_DEBUG=1 is already an improvement. Do you think it would be possible/relevant to record all of the outputs of wrangler and print them when it exists with a non 0 status only (i.e. no need to use debug and no need to print extra info if wrangler succeeds)?

@james-elicx james-elicx changed the title output more wrangler command logs in debug mode output more wrangler command logs on errors Dec 6, 2025
@james-elicx
Copy link
Collaborator Author

Thanks James for looking into that 🙏

I haven't looked at the details of your changes yet but you say "relates to 1030". Do you have any idea why the user does not get error logs there?

Without seeing the full log, it's hard to say. Presumably whatever error they're getting isn't being sent to stderr by Wrangler otherwise I'd expect to see it...

One more thought: having more info with OPEN_NEXT_DEBUG=1 is already an improvement. Do you think it would be possible/relevant to record all of the outputs of wrangler and print them when it exists with a non 0 status only (i.e. no need to use debug and no need to print extra info if wrangler succeeds)?

Makes sense, good idea

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vicb vicb merged commit 721bff0 into main Dec 7, 2025
7 checks passed
@vicb vicb deleted the james/debug-logs branch December 7, 2025 09:51
@james-elicx
Copy link
Collaborator Author

Thanks, sorry I forgot to update the changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants